mirror of
https://git.libssh.org/projects/libssh.git
synced 2025-08-08 19:02:06 +03:00
CVE-2012-4559: Ensure that we don't free req twice.
This commit is contained in:
@@ -1525,6 +1525,7 @@ static int channel_request(ssh_channel channel, const char *request,
|
|||||||
buffer_add_ssh_string(session->out_buffer, req) < 0 ||
|
buffer_add_ssh_string(session->out_buffer, req) < 0 ||
|
||||||
buffer_add_u8(session->out_buffer, reply == 0 ? 0 : 1) < 0) {
|
buffer_add_u8(session->out_buffer, reply == 0 ? 0 : 1) < 0) {
|
||||||
ssh_set_error_oom(session);
|
ssh_set_error_oom(session);
|
||||||
|
ssh_string_free(req);
|
||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
ssh_string_free(req);
|
ssh_string_free(req);
|
||||||
@@ -1584,7 +1585,6 @@ pending:
|
|||||||
return rc;
|
return rc;
|
||||||
error:
|
error:
|
||||||
buffer_reinit(session->out_buffer);
|
buffer_reinit(session->out_buffer);
|
||||||
ssh_string_free(req);
|
|
||||||
|
|
||||||
leave_function();
|
leave_function();
|
||||||
return rc;
|
return rc;
|
||||||
|
Reference in New Issue
Block a user