lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-07-25 03:41:56 +03:00
Code Activity

examples: Fix libssh_scp.c code style

Browse Source 
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Anderson Toshiyuki Sasaki
2018-09-25 16:31:52 +02:00
committed by Andreas Schneider
parent 00e5ef1b3c
commit 6118628424
1 changed files with 322 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

269
examples/libssh_scp.c
View File

@ -25,7 +25,7 @@ program.
static char **sources; static char **sources;
static int nsources; static int nsources;
static char *destination; static char *destination;
static int verbosity=0; static int verbosity = 0;
struct location { struct location {
int is_ssh; int is_ssh;
@ -42,44 +42,50 @@ enum {
WRITE WRITE
}; };
static void usage(const char *argv0){ static void usage(const char *argv0) {
fprintf(stderr,"Usage : %s [options] [[user@]host1:]file1 ... \n" fprintf(stderr, "Usage : %s [options] [[user@]host1:]file1 ... \n"
" [[user@]host2:]destination\n" " [[user@]host2:]destination\n"
"sample scp client - libssh-%s\n", "sample scp client - libssh-%s\n",
// "Options :\n", // "Options :\n",
// " -r : use RSA to verify host public key\n", // " -r : use RSA to verify host public key\n",
argv0, argv0,
ssh_version(0)); ssh_version(0));
exit(0); exit(0);
} }
static int opts(int argc, char **argv){ static int opts(int argc, char **argv) {
int i; int i;
while((i=getopt(argc,argv,"v"))!=-1){
switch(i){ while((i = getopt(argc, argv, "v")) != -1) {
switch(i) {
case 'v': case 'v':
verbosity++; verbosity++;
break; break;
default: default:
fprintf(stderr,"unknown option %c\n",optopt); fprintf(stderr, "unknown option %c\n", optopt);
usage(argv[0]); usage(argv[0]);
return -1; return -1;
} }
} }
nsources=argc-optind-1;
if(nsources < 1){ nsources = argc - optind - 1;
if (nsources < 1) {
usage(argv[0]); usage(argv[0]);
return -1; return -1;
} }
sources=malloc((nsources + 1) * sizeof(char *));
if(sources == NULL) sources = malloc((nsources + 1) * sizeof(char *));
if (sources == NULL) {
return -1; return -1;
for(i=0;i<nsources;++i){ }
for(i = 0; i < nsources; ++i) {
sources[i] = argv[optind]; sources[i] = argv[optind];
optind++; optind++;
} }
sources[i]=NULL;
destination=argv[optind]; sources[i] = NULL;
destination = argv[optind];
return 0; return 0;
} }
@ -108,7 +114,7 @@ static void location_free(struct location *loc)
} }
} }
static struct location *parse_location(char *loc){ static struct location *parse_location(char *loc) {
struct location *location; struct location *location;
char *ptr; char *ptr;
@ -118,23 +124,25 @@ static struct location *parse_location(char *loc){
} }
memset(location, 0, sizeof(struct location)); memset(location, 0, sizeof(struct location));
location->host=location->user=NULL; location->host = location->user = NULL;
ptr=strchr(loc,':'); ptr = strchr(loc, ':');
if(ptr != NULL){
location->is_ssh=1; if (ptr != NULL) {
location->path=strdup(ptr+1); location->is_ssh = 1;
*ptr='\0'; location->path = strdup(ptr+1);
ptr=strchr(loc,'@'); *ptr = '\0';
if(ptr != NULL){ ptr = strchr(loc, '@');
location->host=strdup(ptr+1);
*ptr='\0'; if (ptr != NULL) {
location->user=strdup(loc); location->host = strdup(ptr+1);
*ptr = '\0';
location->user = strdup(loc);
} else { } else {
location->host=strdup(loc); location->host = strdup(loc);
} }
} else { } else {
location->is_ssh=0; location->is_ssh = 0;
location->path=strdup(loc); location->path = strdup(loc);
} }
return location; return location;
} }
@ -168,23 +176,25 @@ static void close_location(struct location *loc) {
} }
} }
static int open_location(struct location *loc, int flag){ static int open_location(struct location *loc, int flag) {
if(loc->is_ssh && flag==WRITE){ if (loc->is_ssh && flag == WRITE) {
loc->session=connect_ssh(loc->host,loc->user,verbosity); loc->session = connect_ssh(loc->host, loc->user, verbosity);
if(!loc->session){ if (!loc->session) {
fprintf(stderr,"Couldn't connect to %s\n",loc->host); fprintf(stderr, "Couldn't connect to %s\n", loc->host);
return -1; return -1;
} }
loc->scp=ssh_scp_new(loc->session,SSH_SCP_WRITE,loc->path);
if(!loc->scp){ loc->scp = ssh_scp_new(loc->session, SSH_SCP_WRITE, loc->path);
fprintf(stderr,"error : %s\n",ssh_get_error(loc->session)); if (!loc->scp) {
fprintf(stderr, "error : %s\n", ssh_get_error(loc->session));
ssh_disconnect(loc->session); ssh_disconnect(loc->session);
ssh_free(loc->session); ssh_free(loc->session);
loc->session = NULL; loc->session = NULL;
return -1; return -1;
} }
if(ssh_scp_init(loc->scp)==SSH_ERROR){
fprintf(stderr,"error : %s\n",ssh_get_error(loc->session)); if (ssh_scp_init(loc->scp) == SSH_ERROR) {
fprintf(stderr, "error : %s\n", ssh_get_error(loc->session));
ssh_scp_free(loc->scp); ssh_scp_free(loc->scp);
loc->scp = NULL; loc->scp = NULL;
ssh_disconnect(loc->session); ssh_disconnect(loc->session);
@ -193,22 +203,24 @@ static int open_location(struct location *loc, int flag){
return -1; return -1;
} }
return 0; return 0;
} else if(loc->is_ssh && flag==READ){ } else if (loc->is_ssh && flag == READ) {
loc->session=connect_ssh(loc->host, loc->user,verbosity); loc->session = connect_ssh(loc->host, loc->user, verbosity);
if(!loc->session){ if (!loc->session) {
fprintf(stderr,"Couldn't connect to %s\n",loc->host); fprintf(stderr, "Couldn't connect to %s\n", loc->host);
return -1; return -1;
} }
loc->scp=ssh_scp_new(loc->session,SSH_SCP_READ,loc->path);
if(!loc->scp){ loc->scp = ssh_scp_new(loc->session, SSH_SCP_READ, loc->path);
fprintf(stderr,"error : %s\n",ssh_get_error(loc->session)); if (!loc->scp) {
fprintf(stderr, "error : %s\n", ssh_get_error(loc->session));
ssh_disconnect(loc->session); ssh_disconnect(loc->session);
ssh_free(loc->session); ssh_free(loc->session);
loc->session = NULL; loc->session = NULL;
return -1; return -1;
} }
if(ssh_scp_init(loc->scp)==SSH_ERROR){
fprintf(stderr,"error : %s\n",ssh_get_error(loc->session)); if (ssh_scp_init(loc->scp) == SSH_ERROR) {
fprintf(stderr, "error : %s\n", ssh_get_error(loc->session));
ssh_scp_free(loc->scp); ssh_scp_free(loc->scp);
loc->scp = NULL; loc->scp = NULL;
ssh_disconnect(loc->session); ssh_disconnect(loc->session);
@ -218,16 +230,20 @@ static int open_location(struct location *loc, int flag){
} }
return 0; return 0;
} else { } else {
loc->file=fopen(loc->path,flag==READ ? "r":"w"); loc->file = fopen(loc->path, flag == READ ? "r":"w");
if(!loc->file){ if (!loc->file) {
if(errno==EISDIR){ if (errno == EISDIR) {
if(chdir(loc->path)){ if (chdir(loc->path)) {
fprintf(stderr,"Error changing directory to %s: %s\n",loc->path,strerror(errno)); fprintf(stderr,
"Error changing directory to %s: %s\n",
loc->path, strerror(errno));
return -1; return -1;
} }
return 0; return 0;
} }
fprintf(stderr,"Error opening %s: %s\n",loc->path,strerror(errno)); fprintf(stderr,
"Error opening %s: %s\n",
loc->path, strerror(errno));
return -1; return -1;
} }
return 0; return 0;
@ -240,153 +256,182 @@ static int open_location(struct location *loc, int flag){
* @param dest destination location * @param dest destination location
* @param recursive Copy also directories * @param recursive Copy also directories
*/ */
static int do_copy(struct location *src, struct location *dest, int recursive){ static int do_copy(struct location *src, struct location *dest, int recursive) {
int size; int size;
socket_t fd; socket_t fd;
struct stat s; struct stat s;
int w,r; int w, r;
char buffer[16384]; char buffer[16384];
int total=0; int total = 0;
int mode; int mode;
char *filename = NULL; char *filename = NULL;
/* recursive mode doesn't work yet */ /* recursive mode doesn't work yet */
(void)recursive; (void)recursive;
/* Get the file name and size*/ /* Get the file name and size*/
if(!src->is_ssh){ if (!src->is_ssh) {
fd = fileno(src->file); fd = fileno(src->file);
if (fd < 0) { if (fd < 0) {
fprintf(stderr, "Invalid file pointer, error: %s\n", strerror(errno)); fprintf(stderr,
"Invalid file pointer, error: %s\n",
strerror(errno));
return -1; return -1;
} }
r = fstat(fd, &s); r = fstat(fd, &s);
if (r < 0) { if (r < 0) {
return -1; return -1;
} }
size=s.st_size; size = s.st_size;
mode = s.st_mode & ~S_IFMT; mode = s.st_mode & ~S_IFMT;
filename=ssh_basename(src->path); filename = ssh_basename(src->path);
} else { } else {
size=0; size = 0;
do { do {
r=ssh_scp_pull_request(src->scp); r = ssh_scp_pull_request(src->scp);
if(r==SSH_SCP_REQUEST_NEWDIR){ if (r == SSH_SCP_REQUEST_NEWDIR) {
ssh_scp_deny_request(src->scp,"Not in recursive mode"); ssh_scp_deny_request(src->scp, "Not in recursive mode");
continue; continue;
} }
if(r==SSH_SCP_REQUEST_NEWFILE){ if (r == SSH_SCP_REQUEST_NEWFILE) {
size=ssh_scp_request_get_size(src->scp); size = ssh_scp_request_get_size(src->scp);
filename=strdup(ssh_scp_request_get_filename(src->scp)); filename = strdup(ssh_scp_request_get_filename(src->scp));
mode=ssh_scp_request_get_permissions(src->scp); mode = ssh_scp_request_get_permissions(src->scp);
//ssh_scp_accept_request(src->scp); //ssh_scp_accept_request(src->scp);
break; break;
} }
if(r==SSH_ERROR){ if (r == SSH_ERROR) {
fprintf(stderr,"Error: %s\n",ssh_get_error(src->session)); fprintf(stderr,
"Error: %s\n",
ssh_get_error(src->session));
ssh_string_free_char(filename); ssh_string_free_char(filename);
return -1; return -1;
} }
} while(r != SSH_SCP_REQUEST_NEWFILE); } while(r != SSH_SCP_REQUEST_NEWFILE);
} }
if(dest->is_ssh){ if (dest->is_ssh) {
r=ssh_scp_push_file(dest->scp,src->path, size, mode); r = ssh_scp_push_file(dest->scp, src->path, size, mode);
// snprintf(buffer,sizeof(buffer),"C0644 %d %s\n",size,src->path); // snprintf(buffer, sizeof(buffer), "C0644 %d %s\n", size, src->path);
if(r==SSH_ERROR){ if (r == SSH_ERROR) {
fprintf(stderr,"error: %s\n",ssh_get_error(dest->session)); fprintf(stderr,
"error: %s\n",
ssh_get_error(dest->session));
ssh_string_free_char(filename); ssh_string_free_char(filename);
ssh_scp_free(dest->scp); ssh_scp_free(dest->scp);
dest->scp = NULL; dest->scp = NULL;
return -1; return -1;
} }
} else { } else {
if(!dest->file){ if (!dest->file) {
dest->file=fopen(filename,"w"); dest->file = fopen(filename, "w");
if(!dest->file){ if (!dest->file) {
fprintf(stderr,"Cannot open %s for writing: %s\n",filename,strerror(errno)); fprintf(stderr,
if(src->is_ssh) "Cannot open %s for writing: %s\n",
ssh_scp_deny_request(src->scp,"Cannot open local file"); filename, strerror(errno));
if (src->is_ssh) {
ssh_scp_deny_request(src->scp, "Cannot open local file");
}
ssh_string_free_char(filename); ssh_string_free_char(filename);
return -1; return -1;
} }
} }
if(src->is_ssh){ if (src->is_ssh) {
ssh_scp_accept_request(src->scp); ssh_scp_accept_request(src->scp);
} }
} }
do { do {
if(src->is_ssh){ if (src->is_ssh) {
r=ssh_scp_read(src->scp,buffer,sizeof(buffer)); r = ssh_scp_read(src->scp, buffer, sizeof(buffer));
if(r==SSH_ERROR){ if (r == SSH_ERROR) {
fprintf(stderr,"Error reading scp: %s\n",ssh_get_error(src->session)); fprintf(stderr,
"Error reading scp: %s\n",
ssh_get_error(src->session));
ssh_string_free_char(filename); ssh_string_free_char(filename);
return -1; return -1;
} }
if(r==0)
if (r == 0) {
break; break;
}
} else { } else {
r=fread(buffer,1,sizeof(buffer),src->file); r = fread(buffer, 1, sizeof(buffer), src->file);
if(r==0) if (r == 0) {
break; break;
if(r<0){ }
fprintf(stderr,"Error reading file: %s\n",strerror(errno));
if (r < 0) {
fprintf(stderr,
"Error reading file: %s\n",
strerror(errno));
ssh_string_free_char(filename); ssh_string_free_char(filename);
return -1; return -1;
} }
} }
if(dest->is_ssh){
w=ssh_scp_write(dest->scp,buffer,r); if (dest->is_ssh) {
if(w == SSH_ERROR){ w = ssh_scp_write(dest->scp, buffer, r);
fprintf(stderr,"Error writing in scp: %s\n",ssh_get_error(dest->session)); if (w == SSH_ERROR) {
fprintf(stderr,
"Error writing in scp: %s\n",
ssh_get_error(dest->session));
ssh_scp_free(dest->scp); ssh_scp_free(dest->scp);
dest->scp=NULL; dest->scp = NULL;
ssh_string_free_char(filename); ssh_string_free_char(filename);
return -1; return -1;
} }
} else { } else {
w=fwrite(buffer,r,1,dest->file); w = fwrite(buffer, r, 1, dest->file);
if(w<=0){ if (w <= 0) {
fprintf(stderr,"Error writing in local file: %s\n",strerror(errno)); fprintf(stderr,
"Error writing in local file: %s\n",
strerror(errno));
ssh_string_free_char(filename); ssh_string_free_char(filename);
return -1; return -1;
} }
} }
total+=r; total += r;
} while(total < size); } while(total < size);
ssh_string_free_char(filename); ssh_string_free_char(filename);
printf("wrote %d bytes\n",total); printf("wrote %d bytes\n", total);
return 0; return 0;
} }
int main(int argc, char **argv){ int main(int argc, char **argv) {
struct location *dest, *src; struct location *dest, *src;
int i; int i;
int r; int r;
if(opts(argc,argv)<0) { if (opts(argc, argv) < 0) {
r = EXIT_FAILURE; r = EXIT_FAILURE;
goto end; goto end;
} }
dest=parse_location(destination);
if(open_location(dest,WRITE)<0) { dest = parse_location(destination);
if (open_location(dest, WRITE) < 0) {
location_free(dest); location_free(dest);
r = EXIT_FAILURE; r = EXIT_FAILURE;
goto end; goto end;
} }
for(i=0;i<nsources;++i){
src=parse_location(sources[i]); for (i = 0; i < nsources; ++i) {
if(open_location(src,READ)<0){ src = parse_location(sources[i]);
if (open_location(src, READ) < 0) {
location_free(src); location_free(src);
r = EXIT_FAILURE; r = EXIT_FAILURE;
goto close_dest; goto close_dest;
} }
if(do_copy(src,dest,0) < 0){
if (do_copy(src, dest, 0) < 0) {
close_location(src); close_location(src);
location_free(src); location_free(src);
break; break;
} }
close_location(src); close_location(src);
location_free(src); location_free(src);
} }
r = 0; r = 0;
close_dest: close_dest: