lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-08-08 19:02:06 +03:00
Code Activity

pki: check ssh_buffer_pack return in ssh_pki_do_sign

Browse Source 
Check the 'ssh_buffer_pack' return in ssh_pki_do_sign for the ED25519 case.

Signed-off-by: Jon Simons <jon@jonsimons.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jon Simons
2014-09-27 02:07:54 -07:00
committed by Andreas Schneider
parent 7edbedf0dd
commit 59da8dab50
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/pki.c
View File

@@ -1453,16 +1453,21 @@ ssh_string ssh_pki_do_sign(ssh_session session,
ssh_buffer buf; ssh_buffer buf;
buf = ssh_buffer_new(); buf = ssh_buffer_new();
if (buf == NULL){ if (buf == NULL) {
ssh_string_free(session_id); ssh_string_free(session_id);
return NULL; return NULL;
} }
ssh_buffer_set_secure(buf); ssh_buffer_set_secure(buf);
ssh_buffer_pack(buf, rc = ssh_buffer_pack(buf,
"SP", "SP",
session_id, session_id,
buffer_get_rest_len(sigbuf), buffer_get_rest(sigbuf)); buffer_get_rest_len(sigbuf), buffer_get_rest(sigbuf));
if (rc != SSH_OK) {
ssh_string_free(session_id);
ssh_buffer_free(buf);
return NULL;
}
sig = pki_do_sign(privkey, sig = pki_do_sign(privkey,
ssh_buffer_get_begin(buf), ssh_buffer_get_begin(buf),