lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-08-10 06:23:01 +03:00
Code Activity

channels: Fix checking for fatal errors.

Browse Source 
We need this that we don't end up in and infinite poll loop.
This commit is contained in:
rofl0r
2011-08-06 10:31:43 +02:00
committed by Andreas Schneider
parent 39f962c91e
commit 563fbe4de8
3 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/channels.c
View File

@@ -1452,6 +1452,11 @@ static int channel_request(ssh_channel channel, const char *request,
} }
while(channel->request_state == SSH_CHANNEL_REQ_STATE_PENDING){ while(channel->request_state == SSH_CHANNEL_REQ_STATE_PENDING){
ssh_handle_packets(session,-1); ssh_handle_packets(session,-1);
if(session->session_state == SSH_SESSION_STATE_ERROR) {
channel->request_state = SSH_CHANNEL_REQ_STATE_ERROR;
break;
}
} }
/* we received something */ /* we received something */
switch (channel->request_state){ switch (channel->request_state){

7
src/poll.c
View File

@@ -612,11 +612,16 @@ int ssh_poll_ctx_dopoll(ssh_poll_ctx ctx, int timeout) {
if (!ctx->pollfds[i].revents) { if (!ctx->pollfds[i].revents) {
i++; i++;
} else { } else {
int ret;
p = ctx->pollptrs[i]; p = ctx->pollptrs[i];
fd = ctx->pollfds[i].fd; fd = ctx->pollfds[i].fd;
revents = ctx->pollfds[i].revents; revents = ctx->pollfds[i].revents;
if (p->cb && p->cb(p, fd, revents, p->cb_data) < 0) { if (p->cb && (ret = p->cb(p, fd, revents, p->cb_data)) < 0) {
if (ret == -2) {
return -1;
}
/* the poll was removed, reload the used counter and start again */ /* the poll was removed, reload the used counter and start again */
used = ctx->polls_used; used = ctx->polls_used;
i=0; i=0;

38
src/socket.c
View File

@@ -246,32 +246,34 @@ int ssh_socket_pollcallback(struct ssh_poll_handle_struct *p, socket_t fd, int r
s->read_wontblock=1; s->read_wontblock=1;
r=ssh_socket_unbuffered_read(s,buffer,sizeof(buffer)); r=ssh_socket_unbuffered_read(s,buffer,sizeof(buffer));
if(r<0){ if(r<0){
if(p != NULL) { if(p != NULL) {
ssh_poll_remove_events(p, POLLIN); ssh_poll_remove_events(p, POLLIN);
} }
if(s->callbacks && s->callbacks->exception){ if(s->callbacks && s->callbacks->exception){
s->callbacks->exception( s->callbacks->exception(
SSH_SOCKET_EXCEPTION_ERROR, SSH_SOCKET_EXCEPTION_ERROR,
s->last_errno,s->callbacks->userdata); s->last_errno,s->callbacks->userdata);
/* p may have been freed, so don't use it /* p may have been freed, so don't use it
* anymore in this function */ * anymore in this function */
p = NULL; p = NULL;
return -2;
} }
} }
if(r==0){ if(r==0){
if(p != NULL) { if(p != NULL) {
ssh_poll_remove_events(p, POLLIN); ssh_poll_remove_events(p, POLLIN);
} }
if(p != NULL) { if(p != NULL) {
ssh_poll_remove_events(p, POLLIN); ssh_poll_remove_events(p, POLLIN);
} }
if(s->callbacks && s->callbacks->exception){ if(s->callbacks && s->callbacks->exception){
s->callbacks->exception( s->callbacks->exception(
SSH_SOCKET_EXCEPTION_EOF, SSH_SOCKET_EXCEPTION_EOF,
0,s->callbacks->userdata); 0,s->callbacks->userdata);
/* p may have been freed, so don't use it /* p may have been freed, so don't use it
* anymore in this function */ * anymore in this function */
p = NULL; p = NULL;
return -2;
} }
} }
if(r>0){ if(r>0){
@@ -282,9 +284,9 @@ int ssh_socket_pollcallback(struct ssh_poll_handle_struct *p, socket_t fd, int r
buffer_get_rest_len(s->in_buffer), buffer_get_rest_len(s->in_buffer),
s->callbacks->userdata); s->callbacks->userdata);
buffer_pass_bytes(s->in_buffer,r); buffer_pass_bytes(s->in_buffer,r);
/* p may have been freed, so don't use it /* p may have been freed, so don't use it
* anymore in this function */ * anymore in this function */
p = NULL; p = NULL;
} }
} }
} }