lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-11-30 13:01:23 +03:00
Code Activity

buffer: Reformat ssh_buffer_get_ssh_string

Browse Source 
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jakub Jelen
2018-09-11 15:55:03 +02:00
committed by Andreas Schneider
parent 03a66b8599
commit 4d09c6dc31
1 changed files with 29 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/buffer.c
View File

@@ -758,13 +758,16 @@ int ssh_buffer_validate_length(struct ssh_buffer_struct *buffer, size_t len)
* *
* @returns The SSH String, NULL on error. * @returns The SSH String, NULL on error.
*/ */
struct ssh_string_struct *ssh_buffer_get_ssh_string(struct ssh_buffer_struct *buffer) { struct ssh_string_struct *
ssh_buffer_get_ssh_string(struct ssh_buffer_struct *buffer)
{
uint32_t stringlen; uint32_t stringlen;
uint32_t hostlen; uint32_t hostlen;
struct ssh_string_struct *str = NULL; struct ssh_string_struct *str = NULL;
int rc; int rc;
if (ssh_buffer_get_u32(buffer, &stringlen) == 0) { rc = ssh_buffer_get_u32(buffer, &stringlen);
if (rc == 0) {
return NULL; return NULL;
} }
hostlen = ntohl(stringlen); hostlen = ntohl(stringlen);
@@ -777,7 +780,9 @@ struct ssh_string_struct *ssh_buffer_get_ssh_string(struct ssh_buffer_struct *bu
if (str == NULL) { if (str == NULL) {
return NULL; return NULL;
} }
if (ssh_buffer_get_data(buffer, ssh_string_data(str), hostlen) != hostlen) {
stringlen = ssh_buffer_get_data(buffer, ssh_string_data(str), hostlen);
if (stringlen != hostlen) {
/* should never happen */ /* should never happen */
SAFE_FREE(str); SAFE_FREE(str);
return NULL; return NULL;