1
0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-04-19 02:24:03 +03:00

security: fix for vulnerability CVE-2014-0017

When accepting a new connection, a forking server based on libssh forks
and the child process handles the request. The RAND_bytes() function of
openssl doesn't reset its state after the fork, but simply adds the
current process id (getpid) to the PRNG state, which is not guaranteed
to be unique.
This can cause several children to end up with same PRNG state which is
a security issue.

Conflicts:
	src/bind.c
This commit is contained in:
Aris Adamantiadis 2014-02-05 21:24:12 +01:00
parent 87549f7bb6
commit 48f0bfc703
4 changed files with 15 additions and 1 deletions

View File

@ -44,5 +44,6 @@ int crypt_set_algorithms_server(ssh_session session);
struct ssh_crypto_struct *crypto_new(void); struct ssh_crypto_struct *crypto_new(void);
void crypto_free(struct ssh_crypto_struct *crypto); void crypto_free(struct ssh_crypto_struct *crypto);
void ssh_reseed(void);
#endif /* WRAPPER_H_ */ #endif /* WRAPPER_H_ */

View File

@ -374,7 +374,8 @@ int ssh_bind_accept(ssh_bind sshbind, ssh_session session) {
ssh_socket_get_poll_handle_out(session->socket); ssh_socket_get_poll_handle_out(session->socket);
session->dsa_key = dsa; session->dsa_key = dsa;
session->rsa_key = rsa; session->rsa_key = rsa;
/* force PRNG to change state in case we fork after ssh_bind_accept */
ssh_reseed();
return SSH_OK; return SSH_OK;
} }

View File

@ -23,6 +23,7 @@
#include <stdlib.h> #include <stdlib.h>
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
#include <sys/time.h>
#include "libssh/priv.h" #include "libssh/priv.h"
#include "libssh/session.h" #include "libssh/session.h"
@ -38,6 +39,8 @@
#include <openssl/rsa.h> #include <openssl/rsa.h>
#include <openssl/hmac.h> #include <openssl/hmac.h>
#include <openssl/opensslv.h> #include <openssl/opensslv.h>
#include <openssl/rand.h>
#ifdef HAVE_OPENSSL_AES_H #ifdef HAVE_OPENSSL_AES_H
#define HAS_AES #define HAS_AES
#include <openssl/aes.h> #include <openssl/aes.h>
@ -66,6 +69,12 @@ static int alloc_key(struct crypto_struct *cipher) {
return 0; return 0;
} }
void ssh_reseed(void){
struct timeval tv;
gettimeofday(&tv, NULL);
RAND_add(&tv, sizeof(tv), 0.0);
}
SHACTX sha1_init(void) { SHACTX sha1_init(void) {
SHACTX c = malloc(sizeof(*c)); SHACTX c = malloc(sizeof(*c));
if (c == NULL) { if (c == NULL) {

View File

@ -41,6 +41,9 @@ static int alloc_key(struct crypto_struct *cipher) {
return 0; return 0;
} }
void ssh_reseed(void){
}
SHACTX sha1_init(void) { SHACTX sha1_init(void) {
SHACTX ctx = NULL; SHACTX ctx = NULL;
gcry_md_open(&ctx, GCRY_MD_SHA1, 0); gcry_md_open(&ctx, GCRY_MD_SHA1, 0);