From 442d22da609ae7e0b92de955d5de08ea07a86b88 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@cryptomilk.org>
Date: Thu, 31 Oct 2019 15:48:38 +0100
Subject: [PATCH] server: Make sure methods is a valid value before casting

Fixes T188

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Jakub Jelen <jjelen@redhat.com>
---
 src/server.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/server.c b/src/server.c
index d34dee9d..917569db 100644
--- a/src/server.c
+++ b/src/server.c
@@ -820,12 +820,17 @@ int ssh_message_auth_kbdint_is_response(ssh_message msg) {
   return msg->auth_request.kbdint_response != 0;
 }
 
+/* FIXME: methods should be unsigned */
 int ssh_message_auth_set_methods(ssh_message msg, int methods) {
   if (msg == NULL || msg->session == NULL) {
     return -1;
   }
 
-  msg->session->auth.supported_methods = methods;
+  if (methods < 0) {
+      return -1;
+  }
+
+  msg->session->auth.supported_methods = (uint32_t)methods;
 
   return 0;
 }