From 2fc77d90cfb8ea13fc020c9995b3797a6ff854ad Mon Sep 17 00:00:00 2001
From: Jakub Jelen <jjelen@redhat.com>
Date: Wed, 20 Mar 2024 11:26:43 +0100
Subject: [PATCH] Run all reviews in single job

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
---
 .gitlab-ci.yml | 30 ++++++++----------------------
 1 file changed, 8 insertions(+), 22 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index b0335cfa..76796323 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -100,35 +100,21 @@ workflow:
 ###############################################################################
 #                                   Review                                    #
 ###############################################################################
-codespell:
-  stage: review
-  image: $CI_REGISTRY/$BUILD_IMAGES_PROJECT:$FEDORA_BUILD
-  script:
-    - codespell --ignore-words-list=keypair,sorce,ned,nd,ue
-  tags:
-    - shared
-  only:
-    - merge_requests
-
-clang-format:
+review:
   variables:
     GIT_DEPTH: 100
   stage: review
   image: $CI_REGISTRY/$BUILD_IMAGES_PROJECT:$FEDORA_BUILD
   script:
-    - ./.gitlab-ci/clang-format-check.sh
-  only:
-    - merge_requests
+    - ERROR=0
+      codespell --ignore-words-list=keypair,sorce,ned,nd,ue || ERROR=1;
+      ./.gitlab-ci/clang-format-check.sh || ERROR=1;
+      ./.gitlab-ci/git-check-signoff-trailer.sh ${CI_MERGE_REQUEST_DIFF_BASE_SHA} || ERROR=1;
+      exit $ERROR
   # the format is not always matching our intentions
   allow_failure: true
-
-git-log-check:
-  variables:
-    GIT_DEPTH: 100
-  image: $CI_REGISTRY/$BUILD_IMAGES_PROJECT:$FEDORA_BUILD
-  stage: review
-  script:
-    - ./.gitlab-ci/git-check-signoff-trailer.sh ${CI_MERGE_REQUEST_DIFF_BASE_SHA}
+  tags:
+    - shared
   only:
     - merge_requests