From 2b5bef9c0380278c89aa3842826c55756d4b87a2 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Mon, 6 Mar 2023 12:16:20 +0100 Subject: [PATCH] gssapi: Free both_supported on error paths (GHSL-2023-033) Thanks Phil Turnbull from GitHub Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/gssapi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gssapi.c b/src/gssapi.c index d073a096..7e4ccaa6 100644 --- a/src/gssapi.c +++ b/src/gssapi.c @@ -229,6 +229,7 @@ ssh_gssapi_handle_userauth(ssh_session session, const char *user, "indicate mechs", maj_stat, min_stat); + gss_release_oid_set(&min_stat, &both_supported); return SSH_ERROR; } @@ -265,8 +266,10 @@ ssh_gssapi_handle_userauth(ssh_session session, const char *user, return SSH_OK; } /* from now we have room for context */ - if (ssh_gssapi_init(session) == SSH_ERROR) + if (ssh_gssapi_init(session) == SSH_ERROR) { + gss_release_oid_set(&min_stat, &both_supported); return SSH_ERROR; + } name_buf.value = service_name; name_buf.length = strlen(name_buf.value) + 1; @@ -278,6 +281,7 @@ ssh_gssapi_handle_userauth(ssh_session session, const char *user, "importing name", maj_stat, min_stat); + gss_release_oid_set(&min_stat, &both_supported); return -1; }