lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-07-29 13:01:13 +03:00
Code Activity

examples: Fix build issue with new clang 15

Browse Source 
The error was  the following

/builds/libssh/libssh-mirror/examples/sshnetcat.c:241:18: error: a function
declaration without a prototype is deprecated in all versions of C
[-Werror,-Wstrict-prototypes]
void cleanup_pcap(){
                 ^
                  void

and similar

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
This commit is contained in:
Jakub Jelen
2022-10-12 13:03:45 +02:00
parent 78978dc6ce
commit 22f0f0dd60
4 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
examples/ssh_X11_client.c
View File

@ -453,7 +453,7 @@ connect_local_xsocket(int display_number)
static int static int
x11_connect_display() x11_connect_display(void)
{ {
int display_number; int display_number;
const char *display = NULL; const char *display = NULL;

3
examples/sshnetcat.c
View File

@ -238,7 +238,8 @@ void set_pcap(ssh_session session){
} }
void cleanup_pcap(void); void cleanup_pcap(void);
void cleanup_pcap(){ void cleanup_pcap(void)
{
ssh_pcap_file_free(pcap); ssh_pcap_file_free(pcap);
pcap = NULL; pcap = NULL;
} }

2
src/init.c
View File

@ -278,7 +278,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL,
* *
* @see ssh_init() * @see ssh_init()
*/ */
bool is_ssh_initialized() { bool is_ssh_initialized(void) {
bool is_initialized = false; bool is_initialized = false;

24
tests/pkd/pkd_keyutil.c
View File

@ -22,7 +22,7 @@
#include "pkd_keyutil.h" #include "pkd_keyutil.h"
#include "pkd_util.h" #include "pkd_util.h"
void setup_rsa_key() { void setup_rsa_key(void) {
int rc = 0; int rc = 0;
if (access(LIBSSH_RSA_TESTKEY, F_OK) != 0) { if (access(LIBSSH_RSA_TESTKEY, F_OK) != 0) {
rc = system_checked(OPENSSH_KEYGEN " -t rsa -q -N \"\" -f " rc = system_checked(OPENSSH_KEYGEN " -t rsa -q -N \"\" -f "
@ -31,7 +31,7 @@ void setup_rsa_key() {
assert_int_equal(rc, 0); assert_int_equal(rc, 0);
} }
void setup_ed25519_key() { void setup_ed25519_key(void) {
int rc = 0; int rc = 0;
if (access(LIBSSH_ED25519_TESTKEY, F_OK) != 0) { if (access(LIBSSH_ED25519_TESTKEY, F_OK) != 0) {
rc = system_checked(OPENSSH_KEYGEN " -t ed25519 -q -N \"\" -f " rc = system_checked(OPENSSH_KEYGEN " -t ed25519 -q -N \"\" -f "
@ -41,7 +41,7 @@ void setup_ed25519_key() {
} }
#ifdef HAVE_DSA #ifdef HAVE_DSA
void setup_dsa_key() { void setup_dsa_key(void) {
int rc = 0; int rc = 0;
if (access(LIBSSH_DSA_TESTKEY, F_OK) != 0) { if (access(LIBSSH_DSA_TESTKEY, F_OK) != 0) {
rc = system_checked(OPENSSH_KEYGEN " -t dsa -q -N \"\" -f " rc = system_checked(OPENSSH_KEYGEN " -t dsa -q -N \"\" -f "
@ -51,7 +51,7 @@ void setup_dsa_key() {
} }
#endif #endif
void setup_ecdsa_keys() { void setup_ecdsa_keys(void) {
int rc = 0; int rc = 0;
if (access(LIBSSH_ECDSA_256_TESTKEY, F_OK) != 0) { if (access(LIBSSH_ECDSA_256_TESTKEY, F_OK) != 0) {
@ -71,27 +71,27 @@ void setup_ecdsa_keys() {
} }
} }
void cleanup_rsa_key() { void cleanup_rsa_key(void) {
cleanup_key(LIBSSH_RSA_TESTKEY); cleanup_key(LIBSSH_RSA_TESTKEY);
} }
void cleanup_ed25519_key() { void cleanup_ed25519_key(void) {
cleanup_key(LIBSSH_ED25519_TESTKEY); cleanup_key(LIBSSH_ED25519_TESTKEY);
} }
#ifdef HAVE_DSA #ifdef HAVE_DSA
void cleanup_dsa_key() { void cleanup_dsa_key(void) {
cleanup_key(LIBSSH_DSA_TESTKEY); cleanup_key(LIBSSH_DSA_TESTKEY);
} }
#endif #endif
void cleanup_ecdsa_keys() { void cleanup_ecdsa_keys(void) {
cleanup_key(LIBSSH_ECDSA_256_TESTKEY); cleanup_key(LIBSSH_ECDSA_256_TESTKEY);
cleanup_key(LIBSSH_ECDSA_384_TESTKEY); cleanup_key(LIBSSH_ECDSA_384_TESTKEY);
cleanup_key(LIBSSH_ECDSA_521_TESTKEY); cleanup_key(LIBSSH_ECDSA_521_TESTKEY);
} }
void setup_openssh_client_keys() { void setup_openssh_client_keys(void) {
int rc = 0; int rc = 0;
if (access(OPENSSH_CA_TESTKEY, F_OK) != 0) { if (access(OPENSSH_CA_TESTKEY, F_OK) != 0) {
@ -184,7 +184,7 @@ void setup_openssh_client_keys() {
} }
} }
void cleanup_openssh_client_keys() { void cleanup_openssh_client_keys(void) {
cleanup_key(OPENSSH_CA_TESTKEY); cleanup_key(OPENSSH_CA_TESTKEY);
cleanup_key(OPENSSH_RSA_TESTKEY); cleanup_key(OPENSSH_RSA_TESTKEY);
cleanup_file(OPENSSH_RSA_TESTKEY "-sha256-cert.pub"); cleanup_file(OPENSSH_RSA_TESTKEY "-sha256-cert.pub");
@ -199,7 +199,7 @@ void cleanup_openssh_client_keys() {
} }
} }
void setup_dropbear_client_rsa_key() { void setup_dropbear_client_rsa_key(void) {
int rc = 0; int rc = 0;
if (access(DROPBEAR_RSA_TESTKEY, F_OK) != 0) { if (access(DROPBEAR_RSA_TESTKEY, F_OK) != 0) {
rc = system_checked(DROPBEAR_KEYGEN " -t rsa -f " rc = system_checked(DROPBEAR_KEYGEN " -t rsa -f "
@ -208,6 +208,6 @@ void setup_dropbear_client_rsa_key() {
assert_int_equal(rc, 0); assert_int_equal(rc, 0);
} }
void cleanup_dropbear_client_rsa_key() { void cleanup_dropbear_client_rsa_key(void) {
unlink(DROPBEAR_RSA_TESTKEY); unlink(DROPBEAR_RSA_TESTKEY);
} }