From 16fd55b4b21e1f68a5310e452215fc65abbe4150 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon@josefsson.org>
Date: Sun, 20 Aug 2023 20:51:57 +0200
Subject: [PATCH] tests: Check ssh_make_padded_bignum_string.

Signed-off-by: Simon Josefsson <simon@josefsson.org>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Sahana Prasad <sahana@redhat.com>
---
 tests/unittests/torture_bignum.c | 53 +++++++++++++++++++++++++++++---
 1 file changed, 48 insertions(+), 5 deletions(-)

diff --git a/tests/unittests/torture_bignum.c b/tests/unittests/torture_bignum.c
index 1884328d..9e67a9c7 100644
--- a/tests/unittests/torture_bignum.c
+++ b/tests/unittests/torture_bignum.c
@@ -6,27 +6,48 @@
 #include "libssh/bignum.h"
 #include "libssh/string.h"
 
-static void check_str (int n, ssh_string str)
+static void check_str(int n, ssh_string str)
 {
     if (n > 0 && n <= 127) {
-        assert_int_equal(1, ntohl (str->size));
+        assert_int_equal(1, ntohl(str->size));
         assert_int_equal(n, str->data[0]);
     } else if (n > 127 && n <= 255) {
-        assert_int_equal(2, ntohl (str->size));
+        assert_int_equal(2, ntohl(str->size));
         assert_int_equal(0, str->data[0]);
         assert_int_equal(n, str->data[1]);
     } else if (n > 255 && n <= 32767) {
-        assert_int_equal(2, ntohl (str->size));
+        assert_int_equal(2, ntohl(str->size));
         assert_int_equal(n >> 8, str->data[0]);
         assert_int_equal(n & 0xFF, str->data[1]);
     } else {
-        assert_int_equal(3, ntohl (str->size));
+        assert_int_equal(3, ntohl(str->size));
         assert_int_equal(n >> 16, str->data[0]);
         assert_int_equal((n >> 8) & 0xFF, str->data[1]);
         assert_int_equal(n & 0xFF, str->data[2]);
     }
 }
 
+static void check_padded_str(int n, ssh_string str)
+{
+    assert_int_equal(4, ntohl(str->size));
+    if (n > 0 && n <= 255) {
+        assert_int_equal(0, str->data[0]);
+        assert_int_equal(0, str->data[1]);
+        assert_int_equal(0, str->data[2]);
+        assert_int_equal(n, str->data[3]);
+    } else if (n > 255 && n <= 65535) {
+        assert_int_equal(0, str->data[0]);
+        assert_int_equal(0, str->data[1]);
+        assert_int_equal(n >> 8, str->data[2]);
+        assert_int_equal(n & 0xFF, str->data[3]);
+    } else {
+        assert_int_equal(0, str->data[0]);
+        assert_int_equal(n >> 16, str->data[1]);
+        assert_int_equal((n >> 8) & 0xFF, str->data[2]);
+        assert_int_equal(n & 0xFF, str->data[3]);
+    }
+}
+
 static void check_bignum(int n, const char *nstr)
 {
     bignum num = NULL, num2 = NULL;
@@ -72,6 +93,28 @@ static void check_bignum(int n, const char *nstr)
     assert_non_null(num3);
     assert_int_equal(0, bignum_cmp(num, num3));
 
+    bignum_safe_free(num2);
+
+    /* ssh_make_padded_bignum_string */
+
+    str = ssh_make_padded_bignum_string(num, 4);
+    assert_non_null(str);
+
+    check_padded_str(n, str);
+
+    num2 = ssh_make_string_bn(str);
+    ssh_string_free(str);
+    assert_non_null(num2);
+
+    ssh_print_bignum("num2", num2);
+
+    assert_true(bignum_cmp(num, num2) == 0);
+
+    dec = bignum_bn2dec(num2);
+    assert_non_null(dec);
+    assert_string_equal(nstr, dec);
+    ssh_crypto_free(dec);
+
     bignum_safe_free(num);
     bignum_safe_free(num2);
     bignum_safe_free(num3);