From 0e756306f05bed2c8419b9d02de8e364280f3edb Mon Sep 17 00:00:00 2001 From: Eshan Kelkar Date: Tue, 13 Aug 2024 17:08:28 +0530 Subject: [PATCH] log.c: Fix current_timestring() The second argument to strftime() should be the size of the buffer as per the manpage. The previous code used size - 1 as the second argument. This commit modifies that behaviour to use buffer size as the second argument of strftime(). Signed-off-by: Eshan Kelkar Reviewed-by: Jakub Jelen --- src/log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/log.c b/src/log.c index bef65a84..4dce5008 100644 --- a/src/log.c +++ b/src/log.c @@ -59,7 +59,7 @@ static int current_timestring(int hires, char *buf, size_t len) { char tbuf[64]; struct timeval tv; - struct tm *tm; + struct tm *tm = NULL; time_t t; gettimeofday(&tv, NULL); @@ -71,10 +71,10 @@ static int current_timestring(int hires, char *buf, size_t len) } if (hires) { - strftime(tbuf, sizeof(tbuf) - 1, "%Y/%m/%d %H:%M:%S", tm); + strftime(tbuf, sizeof(tbuf), "%Y/%m/%d %H:%M:%S", tm); snprintf(buf, len, "%s.%06ld", tbuf, (long)tv.tv_usec); } else { - strftime(tbuf, sizeof(tbuf) - 1, "%Y/%m/%d %H:%M:%S", tm); + strftime(tbuf, sizeof(tbuf), "%Y/%m/%d %H:%M:%S", tm); snprintf(buf, len, "%s", tbuf); }