From 0ce88225c044f9a8c8df847a4397620a2ae8f88b Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Tue, 2 Jul 2024 14:09:34 +0200 Subject: [PATCH] pki: Fix memory leaks from handling pkcs11 uri Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/pki_crypto.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pki_crypto.c b/src/pki_crypto.c index 77a0695f..31d07e73 100644 --- a/src/pki_crypto.c +++ b/src/pki_crypto.c @@ -2819,16 +2819,18 @@ int pki_uri_import(const char *uri_name, if (ossl_type == OSSL_STORE_INFO_PUBKEY && key_type == SSH_KEY_PUBLIC) { pkey = OSSL_STORE_INFO_get1_PUBKEY(info); - break; } else if (ossl_type == OSSL_STORE_INFO_PKEY && key_type == SSH_KEY_PRIVATE) { pkey = OSSL_STORE_INFO_get1_PKEY(info); - break; } else { SSH_LOG(SSH_LOG_TRACE, "Ignoring object not matching our type: %d", ossl_type); + OSSL_STORE_INFO_free(info); + continue; } + OSSL_STORE_INFO_free(info); + break; } OSSL_STORE_close(store); if (pkey == NULL) {