From 0b4b71cc11eab8536ea4677ca0c6f36c3eec2bcc Mon Sep 17 00:00:00 2001 From: Praneeth Sarode Date: Wed, 23 Jul 2025 23:10:50 +0530 Subject: [PATCH] fix(callbacks): make is_callback_valid's behaviour consistent with its name Signed-off-by: Praneeth Sarode Reviewed-by: Jakub Jelen --- src/callbacks.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/callbacks.c b/src/callbacks.c index c95bde31..94ea729e 100644 --- a/src/callbacks.c +++ b/src/callbacks.c @@ -28,7 +28,7 @@ #include "libssh/session.h" #define is_callback_valid(session, cb) \ - (cb->size <= 0 || cb->size > 1024 * sizeof(void *)) + (cb->size > 0 || cb->size <= 1024 * sizeof(void *)) /* LEGACY */ static void ssh_legacy_log_callback(int priority, @@ -59,7 +59,7 @@ int ssh_set_callbacks(ssh_session session, ssh_callbacks cb) return SSH_ERROR; } - if (is_callback_valid(session, cb)) { + if (!is_callback_valid(session, cb)) { ssh_set_error(session, SSH_FATAL, "Invalid callback passed in (badly initialized)"); @@ -88,7 +88,7 @@ static int ssh_add_set_channel_callbacks(ssh_channel channel, } session = channel->session; - if (is_callback_valid(session, cb)) { + if (!is_callback_valid(session, cb)) { ssh_set_error(session, SSH_FATAL, "Invalid callback passed in (badly initialized)"); @@ -144,7 +144,7 @@ int ssh_set_server_callbacks(ssh_session session, ssh_server_callbacks cb) return SSH_ERROR; } - if (is_callback_valid(session, cb)) { + if (!is_callback_valid(session, cb)) { ssh_set_error(session, SSH_FATAL, "Invalid callback passed in (badly initialized)");