From 03f8fcae84efe5e5d65ba5319c16f346df1cd978 Mon Sep 17 00:00:00 2001 From: Ahsen Kamal Date: Wed, 8 Mar 2023 22:53:11 +0530 Subject: [PATCH] fix null dereference of error The Coverity scan CID 1506418 found the null pointer dereferencing Signed-off-by: Ahsen Kamal Reviewed-by: Jakub Jelen (cherry picked from commit 6d3e7e1c44af425ef0934b0306c15ac6253d98e7) --- src/packet_cb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/packet_cb.c b/src/packet_cb.c index d294692e..9f226893 100644 --- a/src/packet_cb.c +++ b/src/packet_cb.c @@ -64,7 +64,9 @@ SSH_PACKET_CALLBACK(ssh_packet_disconnect_callback){ SSH_STRING_FREE(error_s); } - session->peer_discon_msg = strdup(error); + if (error != NULL) { + session->peer_discon_msg = strdup(error); + } SSH_LOG(SSH_LOG_PACKET, "Received SSH_MSG_DISCONNECT %d:%s", code, error != NULL ? error : "no error");