lib/libhttp
1
0
Fork 0
mirror of https://github.com/lammertb/libhttp.git synced 2025-12-22 04:02:04 +03:00
Code Activity

exception if invalid throttle parameter is used

Browse Source 
If '*' is used as `throttle` parameter, there is a segfault
at the first request (see #350). This is a quick fix to avoid the
segfault exception.
Note that in general civetweb.c does not check parameters in advance,
in order to keep the code simple. Other invalid parameters may still
cause exceptions. It is the responsibility of the caller to pass
valid parameters to mg_start.
This commit is contained in:
bel
2016-09-18 21:59:09 +02:00
parent bf2468a880
commit 3b6461d2a0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/civetweb.c
View File

@@ -9680,9 +9680,9 @@ set_throttle(const char *spec, uint32_t remote_ip, const char *uri)
while ((spec = next_option(spec, &vec, &val)) != NULL) { while ((spec = next_option(spec, &vec, &val)) != NULL) {
mult = ','; mult = ',';
if (sscanf(val.ptr, "%lf%c", &v, &mult) < 1 || v < 0 if ((val.ptr == NULL) || (sscanf(val.ptr, "%lf%c", &v, &mult) < 1)
|| (lowercase(&mult) != 'k' && lowercase(&mult) != 'm' || (v < 0) || ((lowercase(&mult) != 'k')
&& mult != ',')) { && (lowercase(&mult) != 'm') && (mult != ','))) {
continue; continue;
} }
v *= (lowercase(&mult) == 'k') v *= (lowercase(&mult) == 'k')