lib/libhttp
1
0
Fork 0
mirror of https://github.com/lammertb/libhttp.git synced 2025-12-22 04:02:04 +03:00
Code Activity

Disable clang unreachable-code warning for function ssl_id_callback

Browse Source 
Checking sizeof(pthread_t) > sizeof(unsigned long) has to be done at compile time,
since the sizeof(...) operator can not be used in "#if" preprocessor conditions.
Thus, depending on the compiler, either the if-branch or the else-branch will be
logically dead code. There seems to be no reasonable way to prevent this, so
disable -Wunreachable-code for this "if" statement.

See #200
This commit is contained in:
bel
2015-09-20 19:13:15 +02:00
parent 4eb38685e7
commit 36eb3a01fb
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/civetweb.c
View File

@@ -9617,6 +9617,17 @@ static unsigned long ssl_id_callback(void)
#ifdef _WIN32
return GetCurrentThreadId();
#else
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunreachable-code"
/* For every compiler, either "sizeof(pthread_t) > sizeof(unsigned long)"
* or not, so one of the two conditions will be unreachable by construction.
* Unfortunately the C standard does not define a way to check this at
* compile time, since the #if preprocessor conditions can not use the sizeof
* operator as an argument. */
#endif
if (sizeof(pthread_t) > sizeof(unsigned long)) {
/* This is the problematic case for CRYPTO_set_id_callback:
* The OS pthread_t can not be cast to unsigned long. */
@@ -9633,6 +9644,11 @@ static unsigned long ssl_id_callback(void)
} else {
return (unsigned long)pthread_self();
}
#ifdef __clang__
#pragma clang diagnostic pop
#endif
#endif
}