Kent Gibson
37f3676cef
tools: tests: avoid splitting and globbing
...
Fix shellcheck SC2046[1], SC2068[2], SC2068[3] and SC2206[4], all of
which are related to avoiding word splitting and globbing.
[1] https://www.shellcheck.net/wiki/SC2046
[2] https://www.shellcheck.net/wiki/SC2068
[3] https://www.shellcheck.net/wiki/SC2086
[4] https://www.shellcheck.net/wiki/SC2206
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-9-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
2f140aed7d
tools: tests: shellcheck don't follow sourced file
...
Fix shellcheck SC1091 - not following.
Use a directive to prevent shellcheck complaining about sourcing
shunit2, which we don't care to check.
[1] https://www.shellcheck.net/wiki/SC1091
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-8-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
934adda133
tools: tests: check exit code directly
...
Fix shellcheck SC2181[1] - check exit code directly.
[1] https://www.shellcheck.net/wiki/SC2181
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-7-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
45f2d4ba38
tools: tests: don't use variables in printf format string
...
Fix shellcheck SC2059[1] - don't use variables in the printf format
string.
[1] https://www.shellcheck.net/wiki/SC2059
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-6-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
48f634ab57
tools: tests: use read -r to avoid mangling backslashes
...
Fix shellcheck SC2162[1] - read without -r will mangle backslashes.
[1] https://www.shellcheck.net/wiki/SC2162
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-5-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
a88ed2f9bf
tools: tests: fix unused variables
...
Fix shellckeck SC2034[1] - foo appears unused.
Prefix intentionally unused variables with "_" and remove variables
not actually used.
[1] https://www.shellcheck.net/wiki/SC2034
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-4-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
57ed5cfe66
tools: tests: declare and assign separately
...
Fix shellcheck SC2155[1] - declare and assign separately to avoid
masking return values.
[1] https://www.shellcheck.net/wiki/SC2155
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-3-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Kent Gibson
ee9751a07d
tools: tests: don't mix string and array
...
Fix shellcheck SC2145[1] - argument mixes string and array.
Separate the command from the array of arguments to avoid mixing.
[1] https://www.shellcheck.net/wiki/SC2145
Signed-off-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240603115628.102616-2-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-06-03 14:02:35 +02:00
Bartosz Golaszewski
b569b91ce1
tools: tests: remove dependency on grep
...
We only use grep in one place where we don't really need it as we can use
find directly.
Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Suggested-by: Kent Gibson <warthog618@gmail.com >
Reviewed-by: Kent Gibson <warthog618@gmail.com >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20240528-fix-bash-tests-v3-4-e9b5be2ba8bf@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-05-29 15:32:00 +02:00
Bartosz Golaszewski
d75d591af7
tools: tests: remove unneeded ';' in while loops
...
We're already breaking the line between while and do so there's no need
for the ';' character.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Reviewed-by: Kent Gibson <warthog618@gmail.com >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20240528-fix-bash-tests-v3-3-e9b5be2ba8bf@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-05-29 15:32:00 +02:00
Bartosz Golaszewski
4fae395c7c
tools: tests: use "$@" instead of $*
...
$@ does not break up quoted arguments which is what we want in all cases
in the bash test-suite. Use it instead of $*. While at it: prevent
globbing with double quotes but allow variable expansion.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Reviewed-by: Kent Gibson <warthog618@gmail.com >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20240528-fix-bash-tests-v3-2-e9b5be2ba8bf@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-05-29 15:32:00 +02:00
Bartosz Golaszewski
649b2baedd
tools: tests: use tabs for indentation consistently
...
Replace all spaces used for indentation with tabs.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Reviewed-by: Kent Gibson <warthog618@gmail.com >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20240528-fix-bash-tests-v3-1-e9b5be2ba8bf@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-05-29 15:32:00 +02:00
Bartosz Golaszewski
35003a821e
tools: tests: accept the new gpio-sim label format in test cases
...
Since kernel commit 840a97e2fbaf ("gpio: sim: delimit the fwnode name
with a ":" when generating labels") the gpio-sim automatic labels are
generated by delimiting the device name and the fwnode name with ':'
instead of '-' for better readability. This will break the tests once
linux v6.9 is out. Act in advance and accept both forms.
Reviewed-by: Kent Gibson <warthog618@gmail.com >
Link: https://lore.kernel.org/r/20240506162506.176935-1-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2024-05-07 11:19:59 +02:00
Bartosz Golaszewski
d8bf05ad61
tools: tests: print additional info when regex matching fails
...
Add shunit assert messages when testing the result of regex matches,
otherwise we're left with a not very useful: "expected:<0> but was:<1>".
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2023-07-03 12:46:48 +02:00
Bartosz Golaszewski
b9b8b689ce
tools: tests: remove a stray newline
...
There's an unnecessary double newline in one of the test cases. Drop it.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
2023-06-22 09:32:39 +02:00
Bartosz Golaszewski
555f5e4cfe
tools: tests: port tests to shunit2
...
BATS has been confirmed to run much more slowly that shunit2. This is
most likely caused by the way BATS evaluates each test file n+1 times
where n is the number of tests[1].
Port tests to using shunit2 which executes as a regular shell script
which, in addition to higher speed, allows for easier debugging as
standard shell flags like -x now work.
[1] https://bats-core.readthedocs.io/en/stable/writing-tests.html
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
Reviewed-by: Kent Gibson <warthog618@gmail.com >
2023-06-22 09:16:21 +02:00
