mirror of
https://git.savannah.gnu.org/git/gnulib.git
synced 2025-08-18 23:42:00 +03:00
OpenBSD treats strerror_r(0,,) as a success, but with a message "Undefined error: 0"; while this is distinct from strerror_r(-1,,) returning "Unknown error: -1", it does not imply success. Meanwhile, if buf is short enough for ERANGE, then we can't use strstr to look for "Unknown" or "Undefined" in the resulting message, like we had been doing for strerror(). Fix this by shifting the burden - now the strerror-override code guarantees that 0 will have an override when needed. * lib/strerror-override.c (strerror_override): Also override 0 when needed. * lib/strerror-override.h (strerror_override): Likewise. * lib/strerror.c (strerror): Simplify, now that 0 override is done earlier. * lib/strerror_r.c (strerror_r): Likewise. * m4/strerror.m4 (gl_FUNC_STRERROR): Split detection of 0 behavior... (gl_FUNC_STRERROR_0): ...into new macro. * m4/strerror_r.m4 (gl_FUNC_STRERROR_R): Replace strerror_r if 0 is overridden. (gl_FUNC_STRERROR_R_WORKS): Avoid extra tests if 0 is broken. * modules/strerror-override (Files): Add strerror.m4. (configure.ac): Also provide override for 0 when needed. * doc/posix-functions/strerror.texi (strerror): Document this. * doc/posix-functions/perror.texi (perror): Likewise. Signed-off-by: Eric Blake <eblake@redhat.com>
34 lines
1.1 KiB
Plaintext
34 lines
1.1 KiB
Plaintext
@node strerror
|
|
@section @code{strerror}
|
|
@findex strerror
|
|
|
|
POSIX specification:@* @url{http://www.opengroup.org/onlinepubs/9699919799/functions/strerror.html}
|
|
|
|
Gnulib module: strerror
|
|
|
|
Portability problems fixed by Gnulib:
|
|
@itemize
|
|
@item
|
|
This function does not support the error values that are specified by POSIX
|
|
but not defined by the system, on some platforms:
|
|
OpenBSD 4.0, OSF/1 5.1, NonStop Kernel, Cygwin 1.5.x, mingw.
|
|
@item
|
|
This function reports failure for @code{strerror(0)} (by setting
|
|
@code{errno} or using a string similar to out-of-range values),
|
|
although POSIX requires this to leave @code{errno} unchanged and
|
|
report success, on some platforms:
|
|
FreeBSD 8.2, OpenBSD 4.7, MacOS X 10.5.
|
|
@item
|
|
This function fails to return a string for out-of-range integers on
|
|
some platforms:
|
|
HP-UX 11, IRIX 6.5, Solaris 8.
|
|
(Some return NULL which is a POSIX violation, others return the empty
|
|
string which is valid but not as useful); this can still cause bugs
|
|
because most programs call @code{strerror} without setting and testing
|
|
@code{errno}.)
|
|
@end itemize
|
|
|
|
Portability problems not fixed by Gnulib:
|
|
@itemize
|
|
@end itemize
|