lib/gnulib
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/gnulib.git synced 2025-08-17 12:41:05 +03:00
Code Activity

getdate: don't leak when TZ contains two or more '"'s

Browse Source 
* lib/getdate.y (get_date): Don't leak a copy of TZ for each
double quote in TZ after the first one.
This commit is contained in:
Jim Meyering
2010-01-18 08:23:24 +01:00
parent 0675829411
commit 2e3e4195c0
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@@ -1,5 +1,9 @@
2010-01-18 Jim Meyering <meyering@redhat.com> 2010-01-18 Jim Meyering <meyering@redhat.com>
getdate: don't leak when TZ contains two or more '"'s
* lib/getdate.y (get_date): Don't leak a copy of TZ for each
double quote in TZ after the first one.
readtokens: do not leak internal token_lengths buffer readtokens: do not leak internal token_lengths buffer
* lib/readtokens.c (readtokens): Free the local, lengths, * lib/readtokens.c (readtokens): Free the local, lengths,
when the supplied "token_lengths" parameter is NULL. when the supplied "token_lengths" parameter is NULL.

2
lib/getdate.y
View File

@@ -1252,6 +1252,8 @@ get_date (struct timespec *result, char const *p, struct timespec const *now)
char tz1buf[TZBUFSIZE]; char tz1buf[TZBUFSIZE];
bool large_tz = TZBUFSIZE < tzsize; bool large_tz = TZBUFSIZE < tzsize;
bool setenv_ok; bool setenv_ok;
/* Free tz0, in case this is the 2nd or subsequent time through. */
free (tz0);
tz0 = get_tz (tz0buf); tz0 = get_tz (tz0buf);
z = tz1 = large_tz ? xmalloc (tzsize) : tz1buf; z = tz1 = large_tz ? xmalloc (tzsize) : tz1buf;
for (s = tzbase; *s != '"'; s++) for (s = tzbase; *s != '"'; s++)