mirror of
https://sourceware.org/git/glibc.git
synced 2025-11-30 11:41:39 +03:00
b9579342c6
The support for lock elision was already deprecated with glibc 2.42: commit77438db8cf"Mark support for lock elision as deprecated." See also discussions: https://sourceware.org/pipermail/libc-alpha/2025-July/168492.html This patch removes the architecture specific support for lock elision for x86, powerpc and s390 by removing the elision-conf.h, elision-conf.c, elision-lock.c, elision-timed.c, elision-unlock.c, elide.h, htm.h/hle.h files. Those generic files are also removed. The architecture specific structures are adjusted and the elision fields are marked as unused. See struct_mutex.h files. Furthermore in struct_rwlock.h, the leftover __rwelision was also removed. Those were originally removed with commit0377a7fde6"nptl: Remove rwlock elision definitions" and by chance reintroduced with commit7df8af43ad"nptl: Add struct_rwlock.h" The common code (e.g. the pthread_mutex-files) are changed back to the time before lock elision was introduced with the x86-support: - commit1cdbe57948"Add the low level infrastructure for pthreads lock elision with TSX" - commitb023e4ca99"Add new internal mutex type flags for elision." - commit68cc29355f"Add minimal test suite changes for elision enabled kernels" - commite8c659d74e"Add elision to pthread_mutex_{try,timed,un}lock" - commit49186d21ef"Disable elision for any pthread_mutexattr_settype call" - commit1717da59ae"Add a configure option to enable lock elision and disable by default" Elision is removed also from the tunables, the initialization part, the pretty-printers and the manual. Some extra handling in the testsuite is removed as well as the full tst-mutex10 testcase, which tested a race while enabling lock elision. I've also searched the code for "elision", "elide", "transaction" and e.g. cleaned some comments. I've run the testsuite on x86_64 and s390x and run the build-many-glibcs.py script. Thanks to Sachin Monga, this patch is also tested on powerpc. A NEWS entry also mentions the removal. Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
137 lines
4.1 KiB
C
137 lines
4.1 KiB
C
/* Copyright (C) 2002-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <pthread.h>
|
|
#include <stdio.h>
|
|
#include <time.h>
|
|
#include <unistd.h>
|
|
#include <sys/time.h>
|
|
#include <stdint.h>
|
|
#include <support/check.h>
|
|
#include <support/timespec.h>
|
|
#include <support/xthread.h>
|
|
|
|
#ifdef ENABLE_PP
|
|
#include "tst-tpp.h"
|
|
#endif
|
|
|
|
#ifndef TYPE
|
|
# define TYPE PTHREAD_MUTEX_NORMAL
|
|
#endif
|
|
|
|
/* A bogus clock value that tells run_test to use
|
|
pthread_mutex_timedlock rather than pthread_mutex_clocklock. */
|
|
#define CLOCK_USE_TIMEDLOCK (-1)
|
|
|
|
static int
|
|
do_test_clock (clockid_t clockid, const char *fnname, int tmo_result)
|
|
{
|
|
pthread_mutex_t m;
|
|
pthread_mutexattr_t a;
|
|
const clockid_t clockid_for_get =
|
|
(clockid == CLOCK_USE_TIMEDLOCK) ? CLOCK_REALTIME : clockid;
|
|
|
|
TEST_COMPARE (pthread_mutexattr_init (&a), 0);
|
|
TEST_COMPARE (pthread_mutexattr_settype (&a, TYPE), 0);
|
|
|
|
#if defined ENABLE_PI
|
|
TEST_COMPARE (pthread_mutexattr_setprotocol (&a, PTHREAD_PRIO_INHERIT), 0);
|
|
#elif defined ENABLE_PP
|
|
TEST_COMPARE (pthread_mutexattr_setprotocol (&a, PTHREAD_PRIO_PROTECT), 0);
|
|
TEST_COMPARE (pthread_mutexattr_setprioceiling (&a, 6), 0);
|
|
#endif
|
|
|
|
int err = pthread_mutex_init (&m, &a);
|
|
if (err != 0)
|
|
{
|
|
#ifdef ENABLE_PI
|
|
if (err == ENOTSUP)
|
|
FAIL_UNSUPPORTED ("PI mutexes unsupported");
|
|
#endif
|
|
FAIL_EXIT1 ("mutex_init failed");
|
|
}
|
|
|
|
TEST_COMPARE (pthread_mutexattr_destroy (&a), 0);
|
|
TEST_COMPARE (pthread_mutex_lock (&m), 0);
|
|
if (pthread_mutex_trylock (&m) == 0)
|
|
FAIL_EXIT1 ("mutex_trylock succeeded");
|
|
|
|
/* Wait 2 seconds. */
|
|
struct timespec ts_timeout = timespec_add (xclock_now (clockid_for_get),
|
|
make_timespec (2, 0));
|
|
|
|
if (clockid == CLOCK_USE_TIMEDLOCK)
|
|
TEST_COMPARE (pthread_mutex_timedlock (&m, &ts_timeout), tmo_result);
|
|
else
|
|
TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
|
|
tmo_result);
|
|
if (tmo_result == ETIMEDOUT)
|
|
TEST_TIMESPEC_BEFORE_NOW (ts_timeout, clockid_for_get);
|
|
|
|
/* The following makes the ts value invalid. */
|
|
ts_timeout.tv_nsec += 1000000000;
|
|
|
|
if (clockid == CLOCK_USE_TIMEDLOCK)
|
|
TEST_COMPARE (pthread_mutex_timedlock (&m, &ts_timeout), EINVAL);
|
|
else
|
|
TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout), EINVAL);
|
|
TEST_COMPARE (pthread_mutex_unlock (&m), 0);
|
|
|
|
const struct timespec ts_start = xclock_now (CLOCK_REALTIME);
|
|
|
|
/* Wait 2 seconds. */
|
|
ts_timeout = timespec_add (ts_start, make_timespec (2, 0));
|
|
|
|
if (clockid == CLOCK_USE_TIMEDLOCK)
|
|
TEST_COMPARE (pthread_mutex_timedlock (&m, &ts_timeout), 0);
|
|
else
|
|
TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout), 0);
|
|
|
|
const struct timespec ts_end = xclock_now (clockid_for_get);
|
|
|
|
/* Check that timedlock didn't delay. We use a limit of 0.1 secs. */
|
|
TEST_TIMESPEC_BEFORE (ts_end,
|
|
timespec_add (ts_start, make_timespec (0, 100000000)));
|
|
|
|
TEST_COMPARE (pthread_mutex_unlock (&m), 0);
|
|
TEST_COMPARE (pthread_mutex_destroy (&m), 0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int do_test (void)
|
|
{
|
|
#ifdef ENABLE_PP
|
|
init_tpp_test ();
|
|
#endif
|
|
|
|
int monotonic_result =
|
|
#ifdef ENABLE_PI
|
|
support_mutex_pi_monotonic () ? ETIMEDOUT : EINVAL;
|
|
#else
|
|
ETIMEDOUT;
|
|
#endif
|
|
|
|
do_test_clock (CLOCK_USE_TIMEDLOCK, "timedlock", ETIMEDOUT);
|
|
do_test_clock (CLOCK_REALTIME, "clocklock(realtime)", ETIMEDOUT);
|
|
do_test_clock (CLOCK_MONOTONIC, "clocklock(monotonic)", monotonic_result);
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|