mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-06 12:01:08 +03:00
3dd2cbfa35
commit 7fec8a5de6
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Nov 13 14:26:08 2025 -0300
Revert __HAVE_64B_ATOMICS configure check
uses 64-bit atomic operations on sem_t if 64-bit atomics are supported.
But sem_t may be aligned to 32-bit on 32-bit architectures.
1. Add a macro, SEM_T_ALIGN, for sem_t alignment.
2. Add a macro, HAVE_UNALIGNED_64B_ATOMICS. Define it if unaligned 64-bit
atomic operations are supported.
3. Add a macro, USE_64B_ATOMICS_ON_SEM_T. Define to 1 if 64-bit atomic
operations are supported and SEM_T_ALIGN is at least 8-byte aligned or
HAVE_UNALIGNED_64B_ATOMICS is defined.
4. Assert that size and alignment of sem_t are not lower than those of
the internal struct new_sem.
5. Check USE_64B_ATOMICS_ON_SEM_T, instead of USE_64B_ATOMICS, when using
64-bit atomic operations on sem_t.
This fixes BZ #33632.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
60 lines
2.0 KiB
C
60 lines
2.0 KiB
C
/* Copyright (C) 2002-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <semaphore.h>
|
|
#include <shlib-compat.h>
|
|
#include "semaphoreP.h"
|
|
#include <atomic.h>
|
|
|
|
|
|
int
|
|
__new_sem_getvalue (sem_t *sem, int *sval)
|
|
{
|
|
struct new_sem *isem = (struct new_sem *) sem;
|
|
|
|
/* XXX Check for valid SEM parameter. */
|
|
/* FIXME This uses relaxed MO, even though POSIX specifies that this function
|
|
should be linearizable. However, its debatable whether linearizability
|
|
is the right requirement. We need to follow up with POSIX and, if
|
|
necessary, use a stronger MO here and elsewhere (e.g., potentially
|
|
release MO in all places where we consume a token). */
|
|
|
|
#if USE_64B_ATOMICS_ON_SEM_T
|
|
*sval = atomic_load_relaxed (&isem->data) & SEM_VALUE_MASK;
|
|
#else
|
|
*sval = atomic_load_relaxed (&isem->value) >> SEM_VALUE_SHIFT;
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
versioned_symbol (libc, __new_sem_getvalue, sem_getvalue, GLIBC_2_34);
|
|
|
|
#if OTHER_SHLIB_COMPAT(libpthread, GLIBC_2_1, GLIBC_2_34)
|
|
compat_symbol (libpthread, __new_sem_getvalue, sem_getvalue, GLIBC_2_1);
|
|
#endif
|
|
|
|
#if OTHER_SHLIB_COMPAT(libpthread, GLIBC_2_0, GLIBC_2_1)
|
|
int
|
|
__old_sem_getvalue (sem_t *sem, int *sval)
|
|
{
|
|
struct old_sem *isem = (struct old_sem *) sem;
|
|
*sval = isem->value;
|
|
return 0;
|
|
}
|
|
compat_symbol (libpthread, __old_sem_getvalue, sem_getvalue, GLIBC_2_0);
|
|
#endif
|