glibc/getsockname.S at ef4ad06fe5a615af9550d74b1b6d546b9dc0a64d - glibc - GitFox

lib/glibc

mirror of https://sourceware.org/git/glibc.git synced 2025-11-03 20:53:13 +03:00

Files

Joseph Myers 935ab81792 Fix resolver bind, getsockname namespace (bug 17733).

On Linux architectures using socketcall, the resolver ends up bringing
in strong symbols for bind and getsockname, which are not in
POSIX.1-1996.  This causes linknamespace test failures:

FAIL: conform/POSIX/pthread.h/linknamespace
FAIL: conform/POSIX/sched.h/linknamespace
FAIL: conform/POSIX/time.h/linknamespace

These functions are defined as strong symbols with __bind and
__getsockname as weak aliases.  This patch switches this to the other
way round by removing the NO_WEAK_ALIAS definitions and so letting the
default case in socket.S act; I see no reason for the existing
arrangements.

Tested for x86 (testsuite, and that disassembly of installed shared
libraries is unchanged by the patch).

	[BZ #17733]
	* sysdeps/unix/sysv/linux/bind.S (NO_WEAK_ALIAS): Do not define.
	(__bind): Do not define as weak alias.
	* sysdeps/unix/sysv/linux/getsockname.S (NO_WEAK_ALIAS): Do not
	define.
	(__getsockname): Do not define as weak alias.

2014-12-22 12:46:27 +00:00

4 lines

63 B

ArmAsm

Raw Blame History

	`#define socket getsockname`
	`#define NARGS 3`
	`#include <socket.S>`