mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-06 12:01:08 +03:00
b9579342c6
The support for lock elision was already deprecated with glibc 2.42: commit77438db8cf"Mark support for lock elision as deprecated." See also discussions: https://sourceware.org/pipermail/libc-alpha/2025-July/168492.html This patch removes the architecture specific support for lock elision for x86, powerpc and s390 by removing the elision-conf.h, elision-conf.c, elision-lock.c, elision-timed.c, elision-unlock.c, elide.h, htm.h/hle.h files. Those generic files are also removed. The architecture specific structures are adjusted and the elision fields are marked as unused. See struct_mutex.h files. Furthermore in struct_rwlock.h, the leftover __rwelision was also removed. Those were originally removed with commit0377a7fde6"nptl: Remove rwlock elision definitions" and by chance reintroduced with commit7df8af43ad"nptl: Add struct_rwlock.h" The common code (e.g. the pthread_mutex-files) are changed back to the time before lock elision was introduced with the x86-support: - commit1cdbe57948"Add the low level infrastructure for pthreads lock elision with TSX" - commitb023e4ca99"Add new internal mutex type flags for elision." - commit68cc29355f"Add minimal test suite changes for elision enabled kernels" - commite8c659d74e"Add elision to pthread_mutex_{try,timed,un}lock" - commit49186d21ef"Disable elision for any pthread_mutexattr_settype call" - commit1717da59ae"Add a configure option to enable lock elision and disable by default" Elision is removed also from the tunables, the initialization part, the pretty-printers and the manual. Some extra handling in the testsuite is removed as well as the full tst-mutex10 testcase, which tested a race while enabling lock elision. I've also searched the code for "elision", "elide", "transaction" and e.g. cleaned some comments. I've run the testsuite on x86_64 and s390x and run the build-many-glibcs.py script. Thanks to Sachin Monga, this patch is also tested on powerpc. A NEWS entry also mentions the removal. Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
100 lines
3.5 KiB
Python
100 lines
3.5 KiB
Python
# Tests for the MutexPrinter class.
|
|
#
|
|
# Copyright (C) 2016-2025 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
#
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
#
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <https://www.gnu.org/licenses/>.
|
|
|
|
import sys
|
|
|
|
from test_printers_common import *
|
|
|
|
test_source = sys.argv[1]
|
|
test_bin = sys.argv[2]
|
|
printer_files = sys.argv[3:]
|
|
printer_names = ['global glibc-pthread-locks']
|
|
|
|
try:
|
|
init_test(test_bin, printer_files, printer_names)
|
|
go_to_main()
|
|
|
|
var = 'mutex'
|
|
to_string = 'pthread_mutex_t'
|
|
|
|
break_at(test_source, 'Test status (destroyed)')
|
|
continue_cmd() # Go to test_status_destroyed
|
|
test_printer(var, to_string, {'Status': 'Destroyed'})
|
|
|
|
break_at(test_source, 'Test status (non-robust)')
|
|
continue_cmd() # Go to test_status_no_robust
|
|
test_printer(var, to_string, {'Status': 'Not acquired'})
|
|
next_cmd()
|
|
thread_id = get_current_thread_lwpid()
|
|
# Owner ID might be reported either as the thread ID or as "Unknown"
|
|
test_printer(var, to_string,
|
|
{'Status': 'Acquired, possibly with no waiters',
|
|
'Owner ID': r'({0}|Unknown)'.format(thread_id)})
|
|
|
|
break_at(test_source, 'Test status (robust)')
|
|
continue_cmd() # Go to test_status_robust
|
|
test_printer(var, to_string, {'Status': 'Not acquired'})
|
|
|
|
# We'll now test the robust mutex locking states. We'll create a new
|
|
# thread that will lock a robust mutex and exit without unlocking it.
|
|
break_at(test_source, 'Create')
|
|
continue_cmd() # Go to test_locking_state_robust
|
|
# Set a breakpoint for the new thread to hit.
|
|
break_at(test_source, 'Thread function')
|
|
continue_cmd()
|
|
# By now the new thread is created and has hit its breakpoint.
|
|
set_scheduler_locking(True)
|
|
parent = 1
|
|
child = 2
|
|
select_thread(child)
|
|
child_id = get_current_thread_lwpid()
|
|
# We've got the new thread's ID.
|
|
select_thread(parent)
|
|
# Make the new thread finish its function while we wait.
|
|
continue_cmd(thread=child)
|
|
# The new thread should be dead by now.
|
|
break_at(test_source, 'Test locking (robust)')
|
|
continue_cmd()
|
|
test_printer(var, to_string, {'Owner ID': r'{0} \(dead\)'.format(child_id)})
|
|
# Try to lock and unlock the mutex.
|
|
next_cmd()
|
|
test_printer(var, to_string, {'Owner ID': thread_id,
|
|
'State protected by this mutex': 'Inconsistent'})
|
|
next_cmd()
|
|
test_printer(var, to_string, {'Status': 'Not acquired',
|
|
'State protected by this mutex': 'Not recoverable'})
|
|
set_scheduler_locking(False)
|
|
|
|
break_at(test_source, 'Test recursive locks')
|
|
continue_cmd() # Go to test_recursive_locks
|
|
test_printer(var, to_string, {'Times acquired by the owner': '2'})
|
|
next_cmd()
|
|
test_printer(var, to_string, {'Times acquired by the owner': '3'})
|
|
continue_cmd() # Exit
|
|
|
|
except (NoLineError, pexpect.TIMEOUT) as exception:
|
|
print('Error: {0}'.format(exception))
|
|
result = FAIL
|
|
|
|
else:
|
|
print('Test succeeded.')
|
|
result = PASS
|
|
|
|
exit(result)
|