mirror of
https://sourceware.org/git/glibc.git
synced 2025-04-19 01:04:13 +03:00
a8110b727e
This patch converts the tst-signal-numbers test from shell + awk to Python. As with gen-as-const, the point is not so much that shell and awk are problematic for this code, as that it's useful to build up general infrastructure in Python for use of a range of code involving extracting values from C headers. This patch moves some code from gen-as-const.py to a new glibcextract.py, which also gains functions relating to listing macros, and comparing the values of a set of macros from compiling two different pieces of code. It's not just signal numbers that should have such tests; pretty much any case where glibc copies constants from Linux kernel headers should have such tests that the values and sets of constants agree except where differences are known to be OK. Much the same also applies to structure layouts (although testing those without hardcoding lists of fields to test will be more complicated). Given this patch, another test for a set of macros would essentially be just a call to glibcextract.compare_macro_consts (plus boilerplate code - and we could move to having separate text files defining such tests, like the .sym inputs to gen-as-const, so that only a single Python script is needed for most such tests). Some such tests would of course need new features, e.g. where the set of macros changes in new kernel versions (so you need to allow new macro names on the kernel side if the kernel headers are newer than the version known to glibc, and extra macros on the glibc side if the kernel headers are older). tst-syscall-list.sh could become a Python script that uses common code to generate lists of macros but does other things with its own custom logic. There are a few differences from the existing shell + awk test. Because the new test evaluates constants using the compiler, no special handling is needed any more for one signal name being defined to another. Because asm/signal.h now needs to pass through the compiler, not just the preprocessor, stddef.h is included as well (given the asm/signal.h issue that it requires an externally provided definition of size_t). The previous code defined __ASSEMBLER__ with asm/signal.h; this is removed (__ASSEMBLY__, a different macro, eliminates the requirement for stddef.h on some but not all architectures). Tested for x86_64, and with build-many-glibcs.py. * scripts/glibcextract.py: New file. * scripts/gen-as-const.py: Do not import os.path, re, subprocess or tempfile. Import glibcexctract. (compute_c_consts): Remove. Moved to glibcextract.py. (gen_test): Update reference to compute_c_consts. (main): Likewise. * sysdeps/unix/sysv/linux/tst-signal-numbers.py: New file. * sysdeps/unix/sysv/linux/tst-signal-numbers.sh: Remove. * sysdeps/unix/sysv/linux/Makefile ($(objpfx)tst-signal-numbers.out): Use tst-signal-numbers.py. Redirect stderr as well as stdout.
112 lines
4.1 KiB
Python
112 lines
4.1 KiB
Python
#!/usr/bin/python3
|
|
# Produce headers of assembly constants from C expressions.
|
|
# Copyright (C) 2018 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
#
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
#
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <http://www.gnu.org/licenses/>.
|
|
|
|
# The input to this script looks like:
|
|
# #cpp-directive ...
|
|
# NAME1
|
|
# NAME2 expression ...
|
|
# A line giving just a name implies an expression consisting of just that name.
|
|
|
|
import argparse
|
|
|
|
import glibcextract
|
|
|
|
|
|
def gen_test(sym_data):
|
|
"""Generate a test for the values of some C constants.
|
|
|
|
The first argument is as for glibcextract.compute_c_consts.
|
|
|
|
"""
|
|
out_lines = []
|
|
for arg in sym_data:
|
|
if isinstance(arg, str):
|
|
if arg == 'START':
|
|
out_lines.append('#include <stdint.h>\n'
|
|
'#include <stdio.h>\n'
|
|
'#include <bits/wordsize.h>\n'
|
|
'#if __WORDSIZE == 64\n'
|
|
'typedef uint64_t c_t;\n'
|
|
'# define U(n) UINT64_C (n)\n'
|
|
'#else\n'
|
|
'typedef uint32_t c_t;\n'
|
|
'# define U(n) UINT32_C (n)\n'
|
|
'#endif\n'
|
|
'static int\n'
|
|
'do_test (void)\n'
|
|
'{\n'
|
|
# Compilation test only, using static
|
|
# assertions.
|
|
' return 0;\n'
|
|
'}\n'
|
|
'#include <support/test-driver.c>')
|
|
else:
|
|
out_lines.append(arg)
|
|
continue
|
|
name = arg[0]
|
|
value = arg[1]
|
|
out_lines.append('_Static_assert (U (asconst_%s) == (c_t) (%s), '
|
|
'"value of %s");'
|
|
% (name, value, name))
|
|
return '\n'.join(out_lines)
|
|
|
|
|
|
def main():
|
|
"""The main entry point."""
|
|
parser = argparse.ArgumentParser(
|
|
description='Produce headers of assembly constants.')
|
|
parser.add_argument('--cc', metavar='CC',
|
|
help='C compiler (including options) to use')
|
|
parser.add_argument('--test', action='store_true',
|
|
help='Generate test case instead of header')
|
|
parser.add_argument('sym_file',
|
|
help='.sym file to process')
|
|
args = parser.parse_args()
|
|
sym_data = []
|
|
with open(args.sym_file, 'r') as sym_file:
|
|
started = False
|
|
for line in sym_file:
|
|
line = line.strip()
|
|
if line == '':
|
|
continue
|
|
# Pass preprocessor directives through.
|
|
if line.startswith('#'):
|
|
sym_data.append(line)
|
|
continue
|
|
words = line.split(maxsplit=1)
|
|
if not started:
|
|
sym_data.append('START')
|
|
started = True
|
|
# Separator.
|
|
if words[0] == '--':
|
|
continue
|
|
name = words[0]
|
|
value = words[1] if len(words) > 1 else words[0]
|
|
sym_data.append((name, value))
|
|
if not started:
|
|
sym_data.append('START')
|
|
if args.test:
|
|
print(gen_test(sym_data))
|
|
else:
|
|
consts = glibcextract.compute_c_consts(sym_data, args.cc)
|
|
print(''.join('#define %s %s\n' % c for c in sorted(consts.items())), end='')
|
|
|
|
if __name__ == '__main__':
|
|
main()
|