mirror of
https://sourceware.org/git/glibc.git
synced 2025-10-27 12:15:39 +03:00
33eff78c8b
POSIX requires that the buffer used by getdelim/getline add a terminating NUL whenever an EOF is read. * libio/iogetdelim.c (__getdelim): Add a NUL byte when the first __underflow is called. * libio/tst-getdelim.c (do_test): Add a test case for the bug. Reviewed-by: Florian Weimer <fweimer@redhat.com>
74 lines
2.4 KiB
C
74 lines
2.4 KiB
C
/* Test getdelim conforming to POSIX specifications.
|
|
|
|
Note: Most getdelim use cases are covered by stdio-common/tst-getline.
|
|
|
|
Copyright (C) 2023-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
|
|
#include <support/check.h>
|
|
#include <support/support.h>
|
|
#include <support/test-driver.h>
|
|
#include <support/xstdio.h>
|
|
#include <support/temp_file.h>
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
/* Check that getdelim sets error indicator on error (BZ #29917) */
|
|
clearerr (stdin);
|
|
TEST_VERIFY (getdelim (0, 0, '\n', stdin) == -1);
|
|
TEST_VERIFY (ferror (stdin) != 0);
|
|
TEST_VERIFY (errno == EINVAL);
|
|
|
|
/* Test getdelim with NUL as delimiter */
|
|
verbose_printf ("Testing NUL delimiter\n");
|
|
char *lineptr = NULL;
|
|
size_t linelen = 0;
|
|
char membuf[] = "abc\0d\nef\0";
|
|
FILE *memstream = xfmemopen (membuf, sizeof (membuf), "r");
|
|
TEST_VERIFY (getdelim (&lineptr, &linelen, '\0', memstream) != -1);
|
|
TEST_COMPARE_BLOB (lineptr, 4, "abc\0", 4);
|
|
TEST_VERIFY (getdelim (&lineptr, &linelen, '\0', memstream) != -1);
|
|
TEST_COMPARE_BLOB (lineptr, 5, "d\nef\0", 5);
|
|
xfclose (memstream);
|
|
free (lineptr);
|
|
|
|
/* Test that getdelim NUL terminates upon reading an EOF from an empty
|
|
file (BZ #28038). This test fails on glibc 2.42 and earlier. */
|
|
lineptr = xmalloc (1);
|
|
lineptr[0] = 'A';
|
|
linelen = 1;
|
|
char *file_name;
|
|
TEST_VERIFY_EXIT (create_temp_file ("tst-getdelim.", &file_name) != -1);
|
|
FILE *fp = fopen (file_name, "r");
|
|
TEST_VERIFY_EXIT (fp != NULL);
|
|
TEST_VERIFY (getdelim (&lineptr, &linelen, '\n', fp) == -1);
|
|
TEST_VERIFY (linelen > 0);
|
|
TEST_VERIFY (lineptr[0] == '\0');
|
|
fclose (fp);
|
|
free (file_name);
|
|
free (lineptr);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|