mirror of
				https://sourceware.org/git/glibc.git
				synced 2025-10-30 10:45:40 +03:00 
			
		
		
		
	This patch implements a new posix_spawn{p} implementation for Linux.  The main
difference is it uses the clone syscall directly with CLONE_VM and CLONE_VFORK
flags and a direct allocated stack.  The new stack and start function solves
most the vfork limitation (possible parent clobber due stack spilling).  The
remaning issue are related to signal handling:
  1. That no signal handlers must run in child context, to avoid corrupt
     parent's state.
  2. Child must synchronize with parent to enforce stack deallocation and
     to possible return execv issues.
The first one is solved by blocking all signals in child, even NPTL-internal
ones (SIGCANCEL and SIGSETXID).  The second issue is done by a stack allocation
in parent and a synchronization with using a pipe or waitpid (in case or error).
The pipe has the advantage of allowing the child signal an exec error (checked
with new tst-spawn2 test).
There is an inherent race condition in pipe2 usage for architectures that do not
support the syscall directly.  In such cases the a pipe plus fctnl is used
instead and it may lead to file descriptor leak in parent (as decribed by fcntl
documentation).
The child process stack is allocate with a mmap with MAP_STACK flag using
default architecture stack size.  Although it is slower than use a stack buffer
from parent, it allows some slack for the compatibility code to run scripts
with no shebang (which may use a buffer with size depending of argument list
count).
Performance should be similar to the vfork default posix implementation and
way faster than fork path (vfork on mostly linux ports are basically
clone with CLONE_VM plus CLONE_VFORK).  The only difference is the syscalls
required for the stack allocation/deallocation.
It fixes BZ#10354, BZ#14750, and BZ#18433.
Tested on i386, x86_64, powerpc64le, and aarch64.
	[BZ #14750]
	[BZ #10354]
	[BZ #18433]
	* include/sched.h (__clone): Add hidden prototype.
	(__clone2): Likewise.
	* include/unistd.h (__dup): Likewise.
	* posix/Makefile (tests): Add tst-spawn2.
	* posix/tst-spawn2.c: New file.
	* sysdeps/posix/dup.c (__dup): Add hidden definition.
	* sysdeps/unix/sysv/linux/aarch64/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/alpha/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/arm/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/hppa/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/i386/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/ia64/clone2.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/m68k/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/microblaze/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/mips/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/nios2/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S (__clone):
	Likewise.
	* sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S (__clone):
	Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-32/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-64/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/sh/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/tile/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/x86_64/clone.S (__clone): Likewise.
	* sysdeps/unix/sysv/linux/nptl-signals.h
	(____nptl_is_internal_signal): New function.
	* sysdeps/unix/sysv/linux/spawni.c: New file.
		
	
		
			
				
	
	
		
			171 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
			
		
		
	
	
			171 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
| /* Copyright (C) 1996-2016 Free Software Foundation, Inc.
 | |
|    This file is part of the GNU C Library.
 | |
|    Contributed by Ralf Baechle <ralf@linux-mips.org>, 1996.
 | |
| 
 | |
|    The GNU C Library is free software; you can redistribute it and/or
 | |
|    modify it under the terms of the GNU Lesser General Public
 | |
|    License as published by the Free Software Foundation; either
 | |
|    version 2.1 of the License, or (at your option) any later version.
 | |
| 
 | |
|    The GNU C Library is distributed in the hope that it will be useful,
 | |
|    but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 | |
|    Lesser General Public License for more details.
 | |
| 
 | |
|    You should have received a copy of the GNU Lesser General Public
 | |
|    License along with the GNU C Library.  If not, see
 | |
|    <http://www.gnu.org/licenses/>.  */
 | |
| 
 | |
| /* clone() is even more special than fork() as it mucks with stacks
 | |
|    and invokes a function in the right context after its all over.  */
 | |
| 
 | |
| #include <sys/asm.h>
 | |
| #include <sysdep.h>
 | |
| #define _ERRNO_H	1
 | |
| #include <bits/errno.h>
 | |
| #include <tls.h>
 | |
| 
 | |
| #define CLONE_VM      0x00000100
 | |
| #define CLONE_THREAD  0x00010000
 | |
| 
 | |
| /* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg,
 | |
| 	     void *parent_tidptr, void *tls, void *child_tidptr) */
 | |
| 
 | |
| 	.text
 | |
| 	.set		nomips16
 | |
| #if _MIPS_SIM == _ABIO32
 | |
| # define EXTRA_LOCALS 1
 | |
| #else
 | |
| # define EXTRA_LOCALS 0
 | |
| #endif
 | |
| LOCALSZ= 4
 | |
| FRAMESZ= (((NARGSAVE+LOCALSZ)*SZREG)+ALSZ)&ALMASK
 | |
| GPOFF= FRAMESZ-(1*SZREG)
 | |
| NESTED(__clone,4*SZREG,sp)
 | |
| #ifdef __PIC__
 | |
| 	SETUP_GP
 | |
| #endif
 | |
| 	PTR_SUBU sp, FRAMESZ
 | |
| 	cfi_adjust_cfa_offset (FRAMESZ)
 | |
| 	SETUP_GP64_STACK (GPOFF, __clone)
 | |
| #ifdef __PIC__
 | |
| 	SAVE_GP (GPOFF)
 | |
| #endif
 | |
| #ifdef PROF
 | |
| 	.set		noat
 | |
| 	move		$1,ra
 | |
| 	jal		_mcount
 | |
| 	.set		at
 | |
| #endif
 | |
| 
 | |
| 
 | |
| 	/* Sanity check arguments.  */
 | |
| 	li		v0,EINVAL
 | |
| 	beqz		a0,L(error)	/* No NULL function pointers.  */
 | |
| 	beqz		a1,L(error)	/* No NULL stack pointers.  */
 | |
| 
 | |
| 	PTR_SUBU	a1,32		/* Reserve argument save space.  */
 | |
| 	PTR_S		a0,0(a1)	/* Save function pointer.  */
 | |
| 	PTR_S		a3,PTRSIZE(a1)	/* Save argument pointer.  */
 | |
| 	LONG_S		a2,(PTRSIZE*2)(a1)	/* Save clone flags.  */
 | |
| 
 | |
| 	move		a0,a2
 | |
| 
 | |
| 	/* Shuffle in the last three arguments - arguments 5, 6, and 7 to
 | |
| 	   this function, but arguments 3, 4, and 5 to the syscall.  */
 | |
| #if _MIPS_SIM == _ABIO32
 | |
| 	PTR_L		a2,(FRAMESZ+PTRSIZE+PTRSIZE+16)(sp)
 | |
| 	PTR_S		a2,16(sp)
 | |
| 	PTR_L		a2,(FRAMESZ+16)(sp)
 | |
| 	PTR_L		a3,(FRAMESZ+PTRSIZE+16)(sp)
 | |
| #else
 | |
| 	move		a2,a4
 | |
| 	move		a3,a5
 | |
| 	move		a4,a6
 | |
| #endif
 | |
| 
 | |
| 	/* Do the system call */
 | |
| 	li		v0,__NR_clone
 | |
| 	cfi_endproc
 | |
| 	syscall
 | |
| 
 | |
| 	bnez		a3,L(error)
 | |
| 	beqz		v0,L(thread_start)
 | |
| 
 | |
| 	/* Successful return from the parent */
 | |
| 	cfi_startproc
 | |
| 	cfi_adjust_cfa_offset (FRAMESZ)
 | |
| 	SETUP_GP64_STACK_CFI (GPOFF)
 | |
| 	cfi_remember_state
 | |
| 	RESTORE_GP64_STACK
 | |
| 	PTR_ADDU	sp, FRAMESZ
 | |
| 	cfi_adjust_cfa_offset (-FRAMESZ)
 | |
| 	ret
 | |
| 
 | |
| 	/* Something bad happened -- no child created */
 | |
| L(error):
 | |
| 	cfi_restore_state
 | |
| #ifdef __PIC__
 | |
| 	PTR_LA		t9,__syscall_error
 | |
| 	RESTORE_GP64_STACK
 | |
| 	PTR_ADDU	sp, FRAMESZ
 | |
| 	cfi_adjust_cfa_offset (-FRAMESZ)
 | |
| 	jr		t9
 | |
| #else
 | |
| 	RESTORE_GP64_STACK
 | |
| 	PTR_ADDU	sp, FRAMESZ
 | |
| 	cfi_adjust_cfa_offset (-FRAMESZ)
 | |
| 	j		__syscall_error
 | |
| #endif
 | |
| 	END(__clone)
 | |
| 
 | |
| /* Load up the arguments to the function.  Put this block of code in
 | |
|    its own function so that we can terminate the stack trace with our
 | |
|    debug info.  */
 | |
| 
 | |
| ENTRY(__thread_start)
 | |
| L(thread_start):
 | |
| 	cfi_undefined ($31)
 | |
| 	/* cp is already loaded.  */
 | |
| 	SAVE_GP (GPOFF)
 | |
| 	/* The stackframe has been created on entry of clone().  */
 | |
| 
 | |
| 	/* Check and see if we need to reset the PID.  */
 | |
| 	LONG_L		a0,(PTRSIZE*2)(sp)
 | |
| 	and		a1,a0,CLONE_THREAD
 | |
| 	beqz		a1,L(restore_pid)
 | |
| L(donepid):
 | |
| 
 | |
| 	/* Restore the arg for user's function.  */
 | |
| 	PTR_L		t9,0(sp)	/* Function pointer.  */
 | |
| 	PTR_L		a0,PTRSIZE(sp)	/* Argument pointer.  */
 | |
| 
 | |
| 	/* Call the user's function.  */
 | |
| 	jal		t9
 | |
| 
 | |
| 	/* Call _exit rather than doing it inline for breakpoint purposes.  */
 | |
| 	move		a0,v0
 | |
| #ifdef __PIC__
 | |
| 	PTR_LA		t9,_exit
 | |
| 	jalr		t9
 | |
| #else
 | |
| 	jal		_exit
 | |
| #endif
 | |
| 
 | |
| L(restore_pid):
 | |
| 	and		a1,a0,CLONE_VM
 | |
| 	li		v0,-1
 | |
| 	bnez		a1,L(gotpid)
 | |
| 	li		v0,__NR_getpid
 | |
| 	syscall
 | |
| L(gotpid):
 | |
| 	READ_THREAD_POINTER(v1)
 | |
| 	INT_S		v0,PID_OFFSET(v1)
 | |
| 	INT_S		v0,TID_OFFSET(v1)
 | |
| 	b		L(donepid)
 | |
| 
 | |
| 	END(__thread_start)
 | |
| 
 | |
| libc_hidden_def (__clone)
 | |
| weak_alias (__clone, clone)
 |