1
0
mirror of https://sourceware.org/git/glibc.git synced 2025-06-03 13:22:05 +03:00
Adhemerval Zanella 7a887dd537 posix: Fix -Warray-bounds instances building timer_create [BZ #26687]
GCC 11 -Warray-bounds triggers invalid warnings when building
Linux timer_create.c:

../sysdeps/unix/sysv/linux/timer_create.c: In function '__timer_create_new':
../sysdeps/unix/sysv/linux/timer_create.c:83:17: warning: array subscript 'struct timer[0]' is partly outside array bounds of 'unsigned char[8]' [-Warray-bounds]
   83 |             newp->sigev_notify = (evp != NULL
      |                 ^~
../sysdeps/unix/sysv/linux/timer_create.c:59:47: note: referencing an object of size 8 allocated by 'malloc'
   59 |         struct timer *newp = (struct timer *) malloc (offsetof (struct timer,
      |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                                                 thrfunc));
      |                                                                 ~~~~~~~~~

The struct allocated for !SIGEV_THREAD timers only requires two 'int'
fields (sigev_notify and ktimerid) and the offsetof trick tries minimize
the memory usage by only allocation the required size.  However,
although the resulting size is suffice for !SIGEV_THREAD time, accessing
the partially allocated object is error-prone and UB.

This patch fixes both issues by embedding the information whether
the timer if a SIGEV_THREAD in the returned 'timer_t'.  For
!SIGEV_THREAD, the resulting 'timer_t' is the returned kernel timer
identifer (kernel_timer_t), while for SIGEV_THREAD it uses the fact
malloc returns at least _Alignof (max_align_t) pointers plus that
valid kernel_timer_t are always positive to set MSB bit of the returned
'timer_t' to indicate the timer handles a SIGEV_THREAD.

It allows to remove the memory allocation for !SIGEV_THREAD and also
remove the 'sigev_notify' field from 'struct timer'.

Checked on x86_64-linux-gnu and i686-linux-gnu.
2020-10-06 15:29:35 -03:00
..
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-07-16 17:55:35 +02:00
2020-09-17 18:49:30 -04:00
2020-09-28 16:21:59 -03:00
2020-09-28 16:21:59 -03:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-09-17 18:49:30 -04:00
2020-07-16 17:55:35 +02:00
2020-07-16 17:55:35 +02:00
2020-08-24 14:27:19 -03:00
2020-09-11 14:41:57 -03:00
2020-08-24 14:28:21 -03:00
2020-08-24 15:04:31 -03:00
2020-09-11 14:35:20 -03:00
2020-09-11 14:35:20 -03:00
2020-09-11 14:35:24 -03:00
2020-09-11 14:35:24 -03:00
2020-09-02 09:16:05 -03:00
2020-02-14 21:12:45 -03:00
2020-09-11 14:35:15 -03:00
2020-09-11 14:35:15 -03:00
2020-08-24 15:04:31 -03:00
2020-09-11 14:42:02 -03:00
2020-04-30 10:42:43 -07:00
2020-09-11 16:20:49 -03:00
2020-02-14 21:12:45 -03:00
2020-09-28 17:28:39 -03:00
2020-07-16 17:55:35 +02:00
2020-09-28 16:21:48 -03:00
2020-02-14 21:12:45 -03:00
2020-02-14 21:12:45 -03:00
2020-01-03 11:22:07 -03:00
2020-02-14 21:12:45 -03:00
2020-08-24 15:04:31 -03:00
2020-07-16 17:55:35 +02:00
2020-09-11 14:35:27 -03:00
2020-09-11 14:35:13 -03:00
2020-09-11 14:35:13 -03:00
2020-09-11 14:35:13 -03:00