mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-18 17:24:29 +03:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
46 lines
1.6 KiB
C
46 lines
1.6 KiB
C
/* Copyright (C) 1997-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <unistd.h>
|
|
#include <sysdep-cancel.h>
|
|
#include <shlib-compat.h>
|
|
|
|
ssize_t
|
|
__libc_pwrite64 (int fd, const void *buf, size_t count, off64_t offset)
|
|
{
|
|
return SYSCALL_CANCEL (pwrite64, fd, buf, count, SYSCALL_LL64_PRW (offset));
|
|
}
|
|
|
|
strong_alias (__libc_pwrite64, __pwrite64)
|
|
libc_hidden_weak (__pwrite64)
|
|
weak_alias (__libc_pwrite64, pwrite64)
|
|
|
|
#ifdef __OFF_T_MATCHES_OFF64_T
|
|
strong_alias (__libc_pwrite64, __libc_pwrite)
|
|
weak_alias (__libc_pwrite64, __pwrite)
|
|
weak_alias (__libc_pwrite64, pwrite)
|
|
|
|
# if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_1, GLIBC_2_2)
|
|
compat_symbol (libc, __libc_pwrite64, pwrite, GLIBC_2_2);
|
|
# endif
|
|
#endif
|
|
|
|
#if SHLIB_COMPAT (libc, GLIBC_2_1, GLIBC_2_2)
|
|
compat_symbol (libc, __libc_pwrite64, pwrite64, GLIBC_2_2);
|
|
compat_symbol (libc, __libc_pwrite64, __pwrite64, GLIBC_2_2);
|
|
#endif
|