mirror of
https://sourceware.org/git/glibc.git
synced 2026-10-24 01:33:52 +03:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
61 lines
2.2 KiB
Makefile
61 lines
2.2 KiB
Makefile
gnulib-arch = $(elf-objpfx)libgcc-stubs.a
|
|
static-gnulib-arch = $(elf-objpfx)libgcc-stubs.a
|
|
|
|
ifeq ($(subdir),elf)
|
|
sysdep-dl-routines += tlsdesc dl-tlsdesc
|
|
sysdep_routines += aeabi_unwind_cpp_pr1 find_exidx
|
|
sysdep-rtld-routines += aeabi_unwind_cpp_pr1
|
|
shared-only-routines += aeabi_unwind_cpp_pr1
|
|
|
|
$(objpfx)libgcc-stubs.a: $(objpfx)aeabi_unwind_cpp_pr1.os
|
|
$(build-extra-lib)
|
|
|
|
lib-noranlib: $(objpfx)libgcc-stubs.a
|
|
|
|
ifeq ($(build-shared),yes)
|
|
ifneq (no,$(have-test-mtls-descriptor))
|
|
tests += tst-armtlsdescloc tst-armtlsdescextnow tst-armtlsdescextlazy
|
|
modules-names += tst-armtlsdesclocmod
|
|
modules-names += tst-armtlsdescextlazymod tst-armtlsdescextnowmod
|
|
CPPFLAGS-tst-armtlsdescextnowmod.c += -Dstatic=
|
|
CPPFLAGS-tst-armtlsdescextlazymod.c += -Dstatic=
|
|
CFLAGS-tst-armtlsdesclocmod.c += -mtls-dialect=$(have-test-mtls-descriptor)
|
|
CFLAGS-tst-armtlsdescextnowmod.c += -mtls-dialect=$(have-test-mtls-descriptor)
|
|
CFLAGS-tst-armtlsdescextlazymod.c += -mtls-dialect=$(have-test-mtls-descriptor)
|
|
LDFLAGS-tst-armtlsdescextnowmod.so += -Wl,-z,now
|
|
tst-armtlsdescloc-ENV = LD_BIND_NOW=1
|
|
tst-armtlsdescextnow-ENV = LD_BIND_NOW=1
|
|
tst-armtlsdescextlazy-ENV = LD_BIND_NOW=1
|
|
$(objpfx)tst-armtlsdescloc: $(objpfx)tst-armtlsdesclocmod.so
|
|
$(objpfx)tst-armtlsdescextnow: $(objpfx)tst-armtlsdescextnowmod.so
|
|
$(objpfx)tst-armtlsdescextlazy: $(objpfx)tst-armtlsdescextlazymod.so
|
|
endif
|
|
endif
|
|
endif
|
|
|
|
ifeq ($(subdir),csu)
|
|
# get offset to rtld_global._dl_hwcap
|
|
gen-as-const-headers += rtld-global-offsets.sym tlsdesc.sym
|
|
aeabi_constants = aeabi_lcsts aeabi_sighandlers aeabi_math
|
|
aeabi_routines = aeabi_assert aeabi_localeconv aeabi_errno_addr \
|
|
aeabi_mb_cur_max aeabi_atexit aeabi_memclr aeabi_memcpy \
|
|
aeabi_memmove aeabi_memset \
|
|
aeabi_read_tp libc-aeabi_read_tp
|
|
|
|
sysdep_routines += $(aeabi_constants) $(aeabi_routines)
|
|
static-only-routines += $(aeabi_constants) aeabi_read_tp
|
|
shared-only-routines += libc-aeabi_read_tp
|
|
|
|
sysdep_routines += arm-unwind-resume
|
|
shared-only-routines += arm-unwind-resume
|
|
endif
|
|
|
|
ifeq ($(subdir),gmon)
|
|
sysdep_routines += arm-mcount
|
|
endif
|
|
|
|
ifeq ($(subdir),rt)
|
|
librt-sysdep_routines += rt-aeabi_unwind_cpp_pr1 rt-arm-unwind-resume
|
|
librt-shared-only-routines += rt-aeabi_unwind_cpp_pr1 rt-arm-unwind-resume
|
|
endif
|