mirror of
https://sourceware.org/git/glibc.git
synced 2026-10-24 01:33:52 +03:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
150 lines
3.8 KiB
Makefile
150 lines
3.8 KiB
Makefile
long-double-fcts = yes
|
|
|
|
ifeq ($(subdir),elf)
|
|
sysdep-dl-routines += \
|
|
dl-bti \
|
|
dl-gcs \
|
|
# sysdep-dl-routines
|
|
|
|
tests += \
|
|
tst-audit26 \
|
|
tst-audit27 \
|
|
# tests
|
|
|
|
modules-names += \
|
|
tst-audit26mod \
|
|
tst-audit27mod \
|
|
tst-auditmod26 \
|
|
tst-auditmod27 \
|
|
# modules-names
|
|
|
|
$(objpfx)tst-audit26: $(objpfx)tst-audit26mod.so \
|
|
$(objpfx)tst-auditmod26.so
|
|
LDFLAGS-tst-audit26 += -Wl,-z,lazy
|
|
tst-audit26-ENV = LD_AUDIT=$(objpfx)tst-auditmod26.so
|
|
|
|
$(objpfx)tst-audit27: $(objpfx)tst-audit27mod.so \
|
|
$(objpfx)tst-auditmod27.so
|
|
$(objpfx)tst-audit27mod.so: $(libsupport)
|
|
LDFLAGS-tst-audit27 += -Wl,-z,lazy
|
|
tst-audit27-ENV = LD_AUDIT=$(objpfx)tst-auditmod27.so
|
|
endif
|
|
|
|
ifeq ($(subdir),elf)
|
|
sysdep-rtld-routines += dl-start
|
|
sysdep-dl-routines += tlsdesc dl-tlsdesc
|
|
gen-as-const-headers += \
|
|
dl-link.sym \
|
|
rtld-global-offsets.sym
|
|
|
|
tests-internal += \
|
|
tst-ifunc-arg-1 \
|
|
tst-ifunc-arg-2 \
|
|
tst-ifunc-arg-3 \
|
|
tst-ifunc-arg-4 \
|
|
# tests-internal
|
|
|
|
tests += tst-vpcs
|
|
modules-names += tst-vpcs-mod
|
|
LDFLAGS-tst-vpcs-mod.so = -Wl,-z,lazy
|
|
$(objpfx)tst-vpcs: $(objpfx)tst-vpcs-mod.so
|
|
endif
|
|
|
|
ifeq ($(subdir),csu)
|
|
gen-as-const-headers += \
|
|
tlsdesc.sym \
|
|
rtld-global-offsets.sym
|
|
endif
|
|
|
|
ifeq ($(subdir),gmon)
|
|
CFLAGS-mcount.c += -mgeneral-regs-only
|
|
endif
|
|
|
|
ifeq ($(subdir),math)
|
|
CPPFLAGS += -I../soft-fp
|
|
endif
|
|
|
|
ifeq ($(subdir),misc)
|
|
sysdep_headers += sys/ifunc.h
|
|
sysdep_routines += \
|
|
__mtag_tag_zero_region \
|
|
__mtag_tag_region \
|
|
__arm_za_disable \
|
|
__alloc_gcs
|
|
|
|
tests += \
|
|
tst-sme-jmp \
|
|
tst-sme-signal \
|
|
tst-sme-za-state \
|
|
# tests
|
|
tests-internal += \
|
|
tst-sme-clone \
|
|
tst-sme-clone3 \
|
|
tst-sme-fork \
|
|
tst-sme-vfork \
|
|
# tests-internal
|
|
|
|
$(objpfx)tst-sme-clone3: $(objpfx)clone3.o $(objpfx)__arm_za_disable.o
|
|
|
|
ifeq (yes,$(have-test-bti))
|
|
|
|
tests += \
|
|
tst-bti-abort-imm \
|
|
tst-bti-abort-transitive \
|
|
tst-bti-abort-unprot \
|
|
tst-bti-dep-prot \
|
|
tst-bti-dlopen-imm \
|
|
tst-bti-dlopen-prot \
|
|
tst-bti-dlopen-transitive \
|
|
tst-bti-permissive-dlopen \
|
|
tst-bti-permissive-imm \
|
|
tst-bti-permissive-transitive \
|
|
# tests
|
|
|
|
modules-names += \
|
|
tst-bti-mod \
|
|
tst-bti-mod-prot \
|
|
tst-bti-mod-unprot \
|
|
# modules-names
|
|
|
|
$(objpfx)tst-bti-abort-imm: $(objpfx)tst-bti-mod-unprot.so
|
|
$(objpfx)tst-bti-abort-transitive: $(objpfx)tst-bti-mod.so
|
|
$(objpfx)tst-bti-abort-unprot: $(objpfx)tst-bti-mod-prot.so
|
|
$(objpfx)tst-bti-dep-prot: $(objpfx)tst-bti-mod-prot.so
|
|
$(objpfx)tst-bti-mod.so: $(objpfx)tst-bti-mod-unprot.so
|
|
$(objpfx)tst-bti-permissive-imm: $(objpfx)tst-bti-mod-unprot.so
|
|
$(objpfx)tst-bti-permissive-transitive: $(objpfx)tst-bti-mod.so
|
|
|
|
CFLAGS-tst-bti-abort-unprot.o += -mbranch-protection=none
|
|
CFLAGS-tst-bti-mod-unprot.os += -mbranch-protection=none
|
|
|
|
tst-bti-abort-imm-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
tst-bti-abort-transitive-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
tst-bti-abort-unprot-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
tst-bti-dep-prot-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
tst-bti-dlopen-imm-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
tst-bti-dlopen-prot-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
tst-bti-dlopen-transitive-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=1
|
|
|
|
tst-bti-permissive-imm-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=0
|
|
tst-bti-permissive-transitive-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=0
|
|
tst-bti-permissive-dlopen-ENV = GLIBC_TUNABLES=glibc.cpu.aarch64_bti=0
|
|
|
|
define run-bti-abort-test
|
|
$(test-wrapper-env) $(run-program-env) \
|
|
$(tst-bti-abort-$*-ENV) $(host-test-program-cmd)
|
|
endef
|
|
|
|
$(objpfx)tst-bti-abort-%.out: $(..)sysdeps/aarch64/tst-bti-abort.sh \
|
|
$(objpfx)tst-bti-abort-%
|
|
$(SHELL) $< $(common-objpfx) $(test-name) '$(run-bti-abort-test)'; \
|
|
$(evaluate-test)
|
|
|
|
endif # ifeq (yes,$(have-test-bti))
|
|
|
|
endif
|
|
|
|
ifeq ($(subdir),malloc)
|
|
sysdep_malloc_debug_routines = __mtag_tag_zero_region __mtag_tag_region
|
|
endif # malloc directory
|