mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-21 17:31:10 +03:00
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
176 lines
4.0 KiB
C
176 lines
4.0 KiB
C
/* Test and measure STRLEN functions.
|
|
Copyright (C) 1999-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#define TEST_MAIN
|
|
#ifndef WIDE
|
|
# define TEST_NAME "strlen"
|
|
#else
|
|
# define TEST_NAME "wcslen"
|
|
#endif
|
|
#include "test-string.h"
|
|
|
|
#ifndef WIDE
|
|
# define STRLEN strlen
|
|
# define CHAR char
|
|
# define MAX_CHAR CHAR_MAX
|
|
#else
|
|
# include <wchar.h>
|
|
# define STRLEN wcslen
|
|
# define CHAR wchar_t
|
|
# define MAX_CHAR WCHAR_MAX
|
|
#endif
|
|
|
|
typedef size_t (*proto_t) (const CHAR *);
|
|
|
|
IMPL (STRLEN, 1)
|
|
|
|
/* Also check the generic implementation. */
|
|
#undef STRLEN
|
|
#undef static_weak_alias
|
|
#define static_weak_alias(a, b)
|
|
#undef libc_hidden_builtin_def
|
|
#define libc_hidden_builtin_def(a)
|
|
#ifndef WIDE
|
|
# define STRLEN __strlen_default
|
|
# include "string/strlen.c"
|
|
IMPL (__strlen_default, 1)
|
|
#else
|
|
# define WCSLEN __wcslen_default
|
|
# include "wcsmbs/wcslen.c"
|
|
IMPL (__wcslen_default, 1)
|
|
#endif
|
|
|
|
|
|
static void
|
|
do_one_test (impl_t *impl, const CHAR *s, size_t exp_len)
|
|
{
|
|
size_t len = CALL (impl, s);
|
|
if (len != exp_len)
|
|
{
|
|
error (0, 0, "Wrong result in function %s %zd %zd", impl->name,
|
|
len, exp_len);
|
|
ret = 1;
|
|
return;
|
|
}
|
|
}
|
|
|
|
static void
|
|
do_test (size_t align, size_t len)
|
|
{
|
|
size_t i;
|
|
|
|
align &= (getpagesize () / sizeof (CHAR)) - 1;
|
|
if (align + sizeof (CHAR) * len >= page_size)
|
|
return;
|
|
|
|
CHAR *buf = (CHAR *) (buf1);
|
|
|
|
for (i = 0; i < len; ++i)
|
|
buf[align + i] = 1 + 11111 * i % MAX_CHAR;
|
|
buf[align + len] = 0;
|
|
|
|
FOR_EACH_IMPL (impl, 0)
|
|
do_one_test (impl, (CHAR *) (buf + align), len);
|
|
}
|
|
|
|
static void
|
|
do_random_tests (void)
|
|
{
|
|
size_t i, j, n, align, len;
|
|
CHAR *p = (CHAR *) (buf1 + page_size - 512 * sizeof (CHAR));
|
|
|
|
for (n = 0; n < ITERATIONS; n++)
|
|
{
|
|
align = random () & 15;
|
|
len = random () & 511;
|
|
if (len + align > 510)
|
|
len = 511 - align - (random () & 7);
|
|
j = len + align + 64;
|
|
if (j > 512)
|
|
j = 512;
|
|
|
|
for (i = 0; i < j; i++)
|
|
{
|
|
if (i == len + align)
|
|
p[i] = 0;
|
|
else
|
|
{
|
|
p[i] = random () & 255;
|
|
if (i >= align && i < len + align && !p[i])
|
|
p[i] = (random () & 127) + 1;
|
|
}
|
|
}
|
|
|
|
FOR_EACH_IMPL (impl, 1)
|
|
if (CALL (impl, (CHAR *) (p + align)) != len)
|
|
{
|
|
error (0, 0, "Iteration %zd - wrong result in function %s (%zd) %zd != %zd, p %p",
|
|
n, impl->name, align, CALL (impl, (CHAR *) (p + align)),
|
|
len, p);
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
int
|
|
test_main (void)
|
|
{
|
|
size_t i;
|
|
|
|
test_init ();
|
|
|
|
printf ("%20s", "");
|
|
FOR_EACH_IMPL (impl, 0)
|
|
printf ("\t%s", impl->name);
|
|
putchar ('\n');
|
|
|
|
/* Checking with only 4 * N alignments for wcslen, other alignments are wrong for wchar_t type arrays*/
|
|
|
|
for (i = 1; i < 8; ++i)
|
|
{
|
|
do_test (sizeof (CHAR) * i, i);
|
|
do_test (0, i);
|
|
}
|
|
|
|
for (i = 2; i <= 12; ++i)
|
|
{
|
|
do_test (0, 1 << i);
|
|
do_test (sizeof (CHAR) * 7, 1 << i);
|
|
do_test (sizeof (CHAR) * i, 1 << i);
|
|
do_test (sizeof (CHAR) * i, (size_t)((1 << i) / 1.5));
|
|
}
|
|
|
|
/* Test strings near page boundary */
|
|
|
|
size_t maxlength = 64 / sizeof (CHAR) - 1;
|
|
size_t pagesize = getpagesize () / sizeof (CHAR);
|
|
|
|
for (i = maxlength ; i > 1; --i)
|
|
{
|
|
/* String stays on the same page. */
|
|
do_test (pagesize - i, i - 1);
|
|
/* String crosses page boundary. */
|
|
do_test (pagesize - i, maxlength);
|
|
}
|
|
|
|
do_random_tests ();
|
|
return ret;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|