mirror of
https://sourceware.org/git/glibc.git
synced 2026-10-24 01:33:52 +03:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
99 lines
2.3 KiB
Makefile
99 lines
2.3 KiB
Makefile
# Copyright (C) 1991-2025 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <https://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
# Sub-makefile for dirent portion of the library.
|
|
#
|
|
subdir := dirent
|
|
|
|
include ../Makeconfig
|
|
|
|
headers := \
|
|
bits/dirent.h \
|
|
bits/dirent_ext.h \
|
|
dirent.h \
|
|
# headers
|
|
routines := \
|
|
alphasort \
|
|
alphasort64 \
|
|
closedir \
|
|
dirfd \
|
|
fdopendir \
|
|
getdents \
|
|
getdents64 \
|
|
opendir \
|
|
readdir \
|
|
readdir64 \
|
|
readdir64_r \
|
|
readdir_r \
|
|
rewinddir \
|
|
scandir \
|
|
scandir-cancel \
|
|
scandir-tail \
|
|
scandir64 \
|
|
scandir64-tail \
|
|
scandirat \
|
|
scandirat64 \
|
|
seekdir \
|
|
telldir \
|
|
versionsort \
|
|
versionsort64 \
|
|
# routines
|
|
|
|
tests := \
|
|
bug-readdir1 \
|
|
list \
|
|
opendir-tst1 \
|
|
tst-closedir-leaks \
|
|
tst-fdopendir \
|
|
tst-fdopendir2 \
|
|
tst-readdir-long \
|
|
tst-readdir-zero-inode \
|
|
tst-rewinddir \
|
|
tst-scandir \
|
|
tst-scandir64 \
|
|
tst-seekdir \
|
|
# tests
|
|
|
|
ifeq ($(run-built-tests),yes)
|
|
ifneq ($(PERL),no)
|
|
generated += \
|
|
$(objpfx)tst-closedir-leaks-mem.out \
|
|
# generated
|
|
|
|
tests-special += \
|
|
$(objpfx)tst-closedir-leaks-mem.out \
|
|
# tests-special
|
|
endif # $(PERL) ! no
|
|
endif # $(run-built-tests) == yes
|
|
|
|
CFLAGS-scandir.c += $(uses-callbacks)
|
|
CFLAGS-scandir64.c += $(uses-callbacks)
|
|
CFLAGS-scandir-tail.c += $(uses-callbacks)
|
|
CFLAGS-scandir64-tail.c += $(uses-callbacks)
|
|
|
|
include ../Rules
|
|
|
|
opendir-tst1-ARGS = --test-dir=${common-objpfx}dirent
|
|
|
|
tst-closedir-leaks-ENV += MALLOC_TRACE=$(objpfx)tst-closedir-leaks.mtrace \
|
|
LD_PRELOAD=$(common-objpfx)/malloc/libc_malloc_debug.so
|
|
|
|
$(objpfx)tst-closedir-leaks-mem.out: $(objpfx)tst-closedir-leaks.out
|
|
$(common-objpfx)malloc/mtrace $(objpfx)tst-closedir-leaks.mtrace > $@; \
|
|
$(evaluate-test)
|