mirror of
				https://sourceware.org/git/glibc.git
				synced 2025-10-30 10:45:40 +03:00 
			
		
		
		
	Recent GCC -Wformat-overflow= changes result in some printf tests failing to build, because those tests are deliberately testing the handling of formats writing more than INT_MAX characters and the handling of NULL arguments to the %s format, which GCC now warns about. This patch duly disables -Wformat-overflow= for the relevant calls to printf functions. Tested with build-many-glibcs.py with GCC mainline for aarch64-linux-gnu. * stdio-common/bug22.c: Include <libc-diag.h>. (do_test): Disable -Wformat-overflow= warnings around fprintf calls outputting more than INT_MAX characters. * stdio-common/tst-printf.c: Disable -Wformat-overflow= warnings around printf call with NULL %s argument.
		
			
				
	
	
		
			79 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			79 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* BZ #5424 */
 | |
| #include <stdio.h>
 | |
| #include <errno.h>
 | |
| #include <libc-diag.h>
 | |
| 
 | |
| /* INT_MAX + 1 */
 | |
| #define N 2147483648
 | |
| 
 | |
| /* (INT_MAX / 2) + 2 */
 | |
| #define N2 1073741825
 | |
| 
 | |
| /* INT_MAX - 3 */
 | |
| #define N3 2147483644
 | |
| 
 | |
| #define STRINGIFY(S) #S
 | |
| #define MAKE_STR(S) STRINGIFY(S)
 | |
| 
 | |
| #define SN MAKE_STR(N)
 | |
| #define SN2 MAKE_STR(N2)
 | |
| #define SN3 MAKE_STR(N3)
 | |
| 
 | |
| static int
 | |
| do_test (void)
 | |
| {
 | |
|   int ret;
 | |
| 
 | |
|   FILE *fp = fopen ("/dev/null", "w");
 | |
|   if (fp == NULL)
 | |
|     {
 | |
|       puts ("cannot open /dev/null");
 | |
|       return 1;
 | |
|     }
 | |
| 
 | |
|   /* GCC 9 warns about output of more than INT_MAX characters; this is
 | |
|      deliberately tested here.  */
 | |
|   DIAG_PUSH_NEEDS_COMMENT;
 | |
| #if __GNUC_PREREQ (7, 0)
 | |
|   DIAG_IGNORE_NEEDS_COMMENT (9, "-Wformat-overflow=");
 | |
| #endif
 | |
|   ret = fprintf (fp, "%" SN "d", 1);
 | |
|   DIAG_POP_NEEDS_COMMENT;
 | |
|   printf ("ret = %d\n", ret);
 | |
|   if (ret != -1 || errno != EOVERFLOW)
 | |
| 	  return 1;
 | |
| 
 | |
|   /* GCC 9 warns about output of more than INT_MAX characters; this is
 | |
|      deliberately tested here.  */
 | |
|   DIAG_PUSH_NEEDS_COMMENT;
 | |
| #if __GNUC_PREREQ (7, 0)
 | |
|   DIAG_IGNORE_NEEDS_COMMENT (9, "-Wformat-overflow=");
 | |
| #endif
 | |
|   ret = fprintf (fp, "%." SN "d", 1);
 | |
|   DIAG_POP_NEEDS_COMMENT;
 | |
|   printf ("ret = %d\n", ret);
 | |
|   if (ret != -1 || errno != EOVERFLOW)
 | |
| 	  return 1;
 | |
| 
 | |
|   ret = fprintf (fp, "%." SN3 "d", 1);
 | |
|   printf ("ret = %d\n", ret);
 | |
|   if (ret != -1 || errno != EOVERFLOW)
 | |
| 	  return 1;
 | |
| 
 | |
|   /* GCC 9 warns about output of more than INT_MAX characters; this is
 | |
|      deliberately tested here.  */
 | |
|   DIAG_PUSH_NEEDS_COMMENT;
 | |
| #if __GNUC_PREREQ (7, 0)
 | |
|   DIAG_IGNORE_NEEDS_COMMENT (9, "-Wformat-overflow=");
 | |
| #endif
 | |
|   ret = fprintf (fp, "%" SN2 "d%" SN2 "d", 1, 1);
 | |
|   DIAG_POP_NEEDS_COMMENT;
 | |
|   printf ("ret = %d\n", ret);
 | |
| 
 | |
|   return ret != -1 || errno != EOVERFLOW;
 | |
| }
 | |
| 
 | |
| #define TIMEOUT 60
 | |
| #define TEST_FUNCTION do_test ()
 | |
| #include "../test-skeleton.c"
 |