1
0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-21 22:22:50 +03:00
Files
glibc/sysdeps/unix/sysv/linux/microblaze/pselect32.c
Thomas Petazzoni c75aa9246a microblaze: Add missing implementation when !__ASSUME_TIME64_SYSCALLS
In commit a92f4e6299 ("linux: Add time64
pselect support"), a Microblaze specific implementation of
__pselect32() was added to cover the case of kernels < 3.15 which lack
the pselect6 system call.

This new file sysdeps/unix/sysv/linux/microblaze/pselect32.c takes
precedence over the default implementation
sysdeps/unix/sysv/linux/pselect32.c.

However sysdeps/unix/sysv/linux/pselect32.c provides an implementation
of __pselect32() which is needed when __ASSUME_TIME64_SYSCALLS is not
defined. On Microblaze, which is a 32-bit architecture,
__ASSUME_TIME64_SYSCALLS is only true for kernels >= 5.1.

Due to sysdeps/unix/sysv/linux/microblaze/pselect32.c taking
precedence over sysdeps/unix/sysv/linux/pselect32.c, it means that
when we are with a kernel >= 3.15 but < 5.1, we need a __pselect32()
implementation, but sysdeps/unix/sysv/linux/microblaze/pselect32.c
doesn't provide it, and sysdeps/unix/sysv/linux/pselect32.c which
would provide it is not compiled in.

This causes the following build failure on Microblaze with for example
Linux kernel headers 4.9:

[...]/build/libc_pic.os: in function `__pselect64':
(.text+0x120b44): undefined reference to `__pselect32'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
2021-12-28 09:09:49 -03:00

63 lines
2.0 KiB
C

/* Synchronous I/O multiplexing. Linux/microblaze version.
Copyright (C) 2019-2021 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <errno.h>
#include <signal.h>
#include <time.h>
#include <sys/poll.h>
#include <sysdep-cancel.h>
#ifndef __ASSUME_TIME64_SYSCALL
#include <sysdeps/unix/sysv/linux/pselect32.c>
#elif !defined __ASSUME_PSELECT
int
__pselect32 (int nfds, fd_set *readfds, fd_set *writefds,
fd_set *exceptfds, const struct __timespec64 *timeout,
const sigset_t *sigmask)
{
/* The fallback uses 'select' which shows the race condition regarding
signal mask set/restore, requires two additional syscalls, and has
a worse timeout precision (microseconds instead of nanoseconds). */
struct timeval tv32, *ptv32 = NULL;
if (timeout != NULL)
{
if (! valid_nanoseconds (timeout->tv_nsec))
{
__set_errno (EINVAL);
return -1;
}
tv32 = valid_timespec64_to_timeval (*timeout);
ptv32 = &tv32;
}
sigset_t savemask;
if (sigmask != NULL)
__sigprocmask (SIG_SETMASK, sigmask, &savemask);
/* select itself is a cancellation entrypoint. */
int ret = __select (nfds, readfds, writefds, exceptfds, ptv32);
if (sigmask != NULL)
__sigprocmask (SIG_SETMASK, &savemask, NULL);
return ret;
}
#endif /* __ASSUME_PSELECT */