Luke Shumaker
2fbce9c203
linux ttyname{_r}: Make tty checks consistent
...
In the ttyname and ttyname_r routines on Linux, at several points it needs to
check if a given TTY is the TTY we are looking for. It used to be that this
check was (to see if `maybe` is `mytty`):
__xstat64(_STAT_VER, maybe_filename, &maybe) == 0
#ifdef _STATBUF_ST_RDEV
&& S_ISCHR(maybe.st_mode) && maybe.st_rdev == mytty.st_rdev
#else
&& maybe.st_ino == mytty.st_ino && maybe.st_dev == mytty.st_dev
#endif
This check appears in several places.
Then, one of the changes made in commit 15e9a4f378c8607c2ae1aa465436af4321db0e23
was to change that check to:
__xstat64(_STAT_VER, maybe_filename, &maybe) == 0
#ifdef _STATBUF_ST_RDEV
&& S_ISCHR(maybe.st_mode) && maybe.st_rdev == mytty.st_rdev
#endif
&& maybe.st_ino == mytty.st_ino && maybe.st_dev == mytty.st_dev
That is, it made the st_ino and st_dev parts of the check happen even if we have
the st_rdev member. This is an important change, because the kernel allows
multiple devpts filesystem instances to be created; a device file in one devpts
instance may share the same st_rdev with a file in another devpts instance, but
they aren't the same file.
This check appears twice in each file (ttyname.c and ttyname_r.c), once (in
ttyname and __ttyname_r) to check if a candidate file found by inspecting /proc
is the desired TTY, and once (in getttyname and getttyname_r) to check if a
candidate file found by searching /dev is the desired TTY. However, 15e9a4f
only updated the checks for files found via /proc; but the concern about
collisions between devpts instances is just as valid for files found via /dev.
So, update all 4 occurrences the check to be consistent with the version of the
check introduced in 15e9a4f. Make it easy to keep all 4 occurrences of the
check consistent by pulling it in to a static inline function, is_mytty.
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
2017-11-15 20:47:07 +01:00
..
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-11-15 18:41:32 +00:00
2017-09-04 13:38:51 -07:00
2017-11-15 18:40:29 +00:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-10-01 16:05:28 -07:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-01-01 00:14:16 +00:00
2017-11-09 05:10:03 -08:00
2017-11-09 05:10:03 -08:00
2017-08-09 22:58:45 +00:00
2017-11-09 05:10:03 -08:00
2017-10-01 15:51:11 -07:00
2017-08-30 22:02:04 +00:00
2017-11-09 05:10:03 -08:00
2017-01-01 00:14:16 +00:00
2017-06-08 13:58:17 -04:00
2017-05-09 21:59:36 +00:00
2017-03-09 15:22:06 +01:00
2017-07-24 11:21:07 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-31 15:59:06 +02:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-03-09 15:22:06 +01:00
2017-05-11 17:27:27 -03:00
2017-05-11 17:27:27 -03:00
2017-01-28 19:21:44 -05:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-13 21:11:38 +02:00
2017-06-08 12:52:42 -07:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-31 16:59:37 +02:00
2017-08-31 16:59:37 +02:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-11-15 14:40:17 -02:00
2017-08-07 19:55:34 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-31 16:10:34 -03:00
2017-01-01 00:14:16 +00:00
2017-05-18 18:06:47 -03:00
2017-09-19 15:50:38 +00:00
2017-08-28 11:58:52 +02:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:08:32 -07:00
2017-10-01 15:08:32 -07:00
2017-05-18 18:06:47 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-31 16:07:52 +02:00
2017-08-28 11:58:52 +02:00
2017-09-01 17:14:43 +00:00
2017-01-01 00:14:16 +00:00
2017-08-31 15:59:07 +02:00
2017-08-31 16:02:40 +02:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-01 16:08:42 -07:00
2017-01-01 00:14:16 +00:00
2017-10-01 18:00:07 -07:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-01 16:12:24 -07:00
2017-10-01 16:12:24 -07:00
2017-10-01 15:57:21 -07:00
2017-01-01 00:14:16 +00:00
2017-09-25 18:04:16 -07:00
2017-10-01 18:02:10 -07:00
2017-09-25 18:04:16 -07:00
2017-09-25 18:04:16 -07:00
2017-09-08 16:34:02 +02:00
2017-09-08 16:34:02 +02:00
2017-08-18 18:38:55 -03:00
2017-11-15 08:58:48 -08:00
2017-09-27 17:18:32 -07:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:08:32 -07:00
2017-10-01 15:08:32 -07:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2016-11-22 09:59:12 -08:00
2017-01-01 00:14:16 +00:00
2017-09-19 16:19:14 +02:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:26:24 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-11-07 12:11:42 +01:00
2017-08-18 18:38:55 -03:00
2017-06-23 17:38:17 -03:00
2017-08-14 10:35:14 -03:00
2017-08-14 10:35:14 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-05-18 18:06:47 -03:00
2017-05-18 18:06:47 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-05-18 18:06:47 -03:00
2017-08-22 14:25:08 -03:00
2017-08-13 21:11:28 +02:00
2017-10-01 15:56:27 -07:00
2017-08-31 16:10:34 -03:00
2017-07-24 11:21:07 -03:00
2017-05-20 19:04:43 -04:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:07:23 -07:00
2017-09-25 18:04:16 -07:00
2017-08-17 16:50:35 -03:00
2017-05-18 18:06:47 -03:00
2017-08-17 16:50:35 -03:00
2017-08-18 16:30:05 -03:00
2017-08-18 16:30:05 -03:00
2017-01-01 00:14:16 +00:00
2017-08-17 10:18:15 +02:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:18:25 -07:00
2017-08-22 14:25:03 -03:00
2017-01-01 00:14:16 +00:00
2017-05-03 10:36:01 -03:00
2017-10-01 18:06:04 -07:00
2017-02-06 10:21:55 -02:00
2017-10-01 18:06:04 -07:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-05-02 14:57:40 -03:00
2017-05-02 14:57:40 -03:00
2017-08-08 09:59:46 -03:00
2017-08-31 18:52:00 +02:00
2017-08-08 09:59:46 -03:00
2017-08-31 18:52:00 +02:00
2017-05-09 14:05:09 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-06-07 17:37:59 +02:00
2017-05-31 17:35:46 -03:00
2017-05-02 14:57:40 -03:00
2017-08-08 09:59:46 -03:00
2017-08-31 18:52:00 +02:00
2017-08-08 09:59:46 -03:00
2017-08-31 18:52:00 +02:00
2017-01-01 00:14:16 +00:00
2017-08-18 10:31:16 -03:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:51:11 -07:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:54:10 -07:00
2017-01-01 00:14:16 +00:00
2017-03-09 15:22:06 +01:00
2017-03-09 15:22:06 +01:00
2017-05-09 21:59:36 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-01 18:03:59 -07:00
2017-05-03 10:36:36 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-03-09 15:22:06 +01:00
2017-05-09 21:59:36 +00:00
2017-01-01 00:14:16 +00:00
2017-03-09 15:22:06 +01:00
2017-03-28 12:29:27 -03:00
2017-03-28 12:29:27 -03:00
2017-03-28 12:29:27 -03:00
2017-03-28 12:29:27 -03:00
2017-01-01 00:14:16 +00:00
2017-03-28 12:29:27 -03:00
2017-03-28 12:29:27 -03:00
2017-03-28 12:29:27 -03:00
2017-03-28 12:29:27 -03:00
2017-10-01 17:46:54 -07:00
2017-10-01 17:46:54 -07:00
2017-01-01 00:14:16 +00:00
2017-10-01 16:12:24 -07:00
2017-03-28 12:29:27 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-31 17:49:18 -02:00
2017-11-06 17:37:57 -02:00
2017-01-01 00:14:16 +00:00
2017-05-20 19:04:43 -04:00
2017-01-01 00:14:16 +00:00
2017-05-18 18:06:47 -03:00
2017-11-06 17:37:57 -02:00
2017-11-06 17:37:57 -02:00
2017-11-06 17:37:57 -02:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-23 13:31:26 -02:00
2017-01-01 00:14:16 +00:00
2017-05-18 18:06:47 -03:00
2017-01-01 00:14:16 +00:00
2017-10-01 15:08:32 -07:00
2017-10-01 15:08:32 -07:00
2017-01-01 00:14:16 +00:00
2017-09-04 20:16:07 +00:00
2017-05-18 18:06:47 -03:00
2017-08-18 18:38:55 -03:00
2017-01-01 00:14:16 +00:00
2017-10-11 14:27:24 -03:00
2017-01-01 00:14:16 +00:00
2017-03-09 15:22:06 +01:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-10-01 17:48:24 -07:00
2017-01-01 00:14:16 +00:00
2017-06-23 17:38:17 -03:00
2017-05-18 18:06:47 -03:00
2017-11-02 13:55:51 +01:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-06-07 14:05:42 +02:00
2017-06-26 17:52:20 -03:00
2017-03-01 20:32:50 -05:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-05-08 16:44:54 +00:00
2017-06-20 20:32:50 -04:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-02-16 17:33:18 -05:00
2017-08-28 11:58:52 +02:00
2017-10-20 04:10:15 +02:00
2017-10-20 04:10:15 +02:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-11-15 20:47:07 +01:00
2017-11-15 20:47:07 +01:00
2017-11-15 20:47:07 +01:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-11-06 17:37:57 -02:00
2017-05-18 18:06:47 -03:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-08-21 15:37:45 -03:00
2017-08-18 10:53:47 -03:00
2017-10-01 15:54:10 -07:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00
2017-01-01 00:14:16 +00:00