mirror of
https://sourceware.org/git/glibc.git
synced 2025-09-10 00:49:40 +03:00
This patches fixes BZ#16430 by setting a different symbol for internal GLIBC calls that points to ifunc resolvers. For PPC32, if the symbol is defined as hidden (which is the case for gettimeofday and time) the compiler will create local branches (symbol@local) and linker will not create PLT calls (required for IFUNC). This will leads to internal symbol calling the IFUNC resolver instead of the resolved symbol. For PPC64 this behavior does not occur because a call to a function in another translation unit might use a different toc pointer thus requiring a PLT call.
81 lines
2.5 KiB
C
81 lines
2.5 KiB
C
/* Copyright (C) 2005-2014 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
#include <sys/time.h>
|
|
|
|
#ifdef SHARED
|
|
|
|
# include <dl-vdso.h>
|
|
# include <bits/libc-vdso.h>
|
|
# include <dl-machine.h>
|
|
|
|
void *gettimeofday_ifunc (void) __asm__ ("__gettimeofday");
|
|
|
|
static int
|
|
__gettimeofday_syscall (struct timeval *tv, struct timezone *tz)
|
|
{
|
|
return INLINE_SYSCALL (gettimeofday, 2, tv, tz);
|
|
}
|
|
|
|
void *
|
|
gettimeofday_ifunc (void)
|
|
{
|
|
/* If the vDSO is not available we fall back syscall. */
|
|
return (__vdso_gettimeofday ? VDSO_IFUNC_RET (__vdso_gettimeofday)
|
|
: __gettimeofday_syscall);
|
|
}
|
|
asm (".type __gettimeofday, %gnu_indirect_function");
|
|
|
|
/* This is doing "libc_hidden_def (__gettimeofday)" but the compiler won't
|
|
let us do it in C because it doesn't know we're defining __gettimeofday
|
|
here in this file. */
|
|
asm (".globl __GI___gettimeofday");
|
|
|
|
/* __GI___gettimeofday is defined as hidden and for ppc32 it enables the
|
|
compiler make a local call (symbol@local) for internal GLIBC usage. It
|
|
means the PLT won't be used and the ifunc resolver will be called directly.
|
|
For ppc64 a call to a function in another translation unit might use a
|
|
different toc pointer thus disallowing direct branchess and making internal
|
|
ifuncs calls safe. */
|
|
#ifdef __powerpc64__
|
|
asm ("__GI___gettimeofday = __gettimeofday");
|
|
#else
|
|
int
|
|
__gettimeofday_vsyscall (struct timeval *tv, struct timezone *tz)
|
|
{
|
|
return INLINE_VSYSCALL (gettimeofday, 2, tv, tz);
|
|
}
|
|
asm ("__GI___gettimeofday = __gettimeofday_vsyscall");
|
|
#endif
|
|
|
|
#else
|
|
|
|
# include <sysdep.h>
|
|
# include <errno.h>
|
|
|
|
int
|
|
__gettimeofday (struct timeval *tv, struct timezone *tz)
|
|
{
|
|
return INLINE_SYSCALL (gettimeofday, 2, tv, tz);
|
|
}
|
|
libc_hidden_def (__gettimeofday)
|
|
|
|
#endif
|
|
weak_alias (__gettimeofday, gettimeofday)
|
|
libc_hidden_weak (gettimeofday)
|