mirror of
https://sourceware.org/git/glibc.git
synced 2025-07-30 22:43:12 +03:00
848f0e46f0
Compiler generates the following instruction sequence for dynamic TLS access: leal tls_var@tlsgd(,%ebx,1), %eax call ___tls_get_addr@PLT CALL instruction is transparent to compiler which assumes all registers, except for EFLAGS, AX, CX, and DX, are unchanged after CALL. But ___tls_get_addr is a normal function which doesn't preserve any vector registers. 1. Rename the generic __tls_get_addr function to ___tls_get_addr_internal. 2. Change ___tls_get_addr to a wrapper function with implementations for FNSAVE, FXSAVE, XSAVE and XSAVEC to save and restore all vector registers. 3. dl-tlsdesc-dynamic.h has: _dl_tlsdesc_dynamic: /* Like all TLS resolvers, preserve call-clobbered registers. We need two scratch regs anyway. */ subl $32, %esp cfi_adjust_cfa_offset (32) It is wrong to use movl %ebx, -28(%esp) movl %esp, %ebx cfi_def_cfa_register(%ebx) ... mov %ebx, %esp cfi_def_cfa_register(%esp) movl -28(%esp), %ebx to preserve EBX on stack. Fix it with: movl %ebx, 28(%esp) movl %esp, %ebx cfi_def_cfa_register(%ebx) ... mov %ebx, %esp cfi_def_cfa_register(%esp) movl 28(%esp), %ebx 4. Update _dl_tlsdesc_dynamic to call ___tls_get_addr_internal directly. 5. Add have-test-mtls-traditional to compile tst-tls23-mod.c with traditional TLS variant to verify the fix. 6. Define DL_RUNTIME_RESOLVE_REALIGN_STACK in sysdeps/x86/sysdep.h. This fixes BZ #32996. Co-Authored-By: Adhemerval Zanella <adhemerval.zanella@linaro.org> Signed-off-by: H.J. Lu <hjl.tools@gmail.com> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
43 lines
1.4 KiB
C
43 lines
1.4 KiB
C
/* Thread-local storage handling in the ELF dynamic linker. i386 version.
|
|
Copyright (C) 2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
.hidden ___tls_get_addr
|
|
.global ___tls_get_addr
|
|
.type ___tls_get_addr,@function
|
|
|
|
/* This function is a wrapper of ___tls_get_addr_internal to
|
|
preserve caller-saved vector registers. */
|
|
|
|
cfi_startproc
|
|
.align 16
|
|
___tls_get_addr:
|
|
/* Like all TLS resolvers, preserve call-clobbered registers.
|
|
We need two scratch regs anyway. */
|
|
subl $32, %esp
|
|
cfi_adjust_cfa_offset (32)
|
|
movl %ecx, 20(%esp)
|
|
movl %edx, 24(%esp)
|
|
#include "tls-get-addr-wrapper.h"
|
|
movl 20(%esp), %ecx
|
|
movl 24(%esp), %edx
|
|
addl $32, %esp
|
|
cfi_adjust_cfa_offset (-32)
|
|
ret
|
|
cfi_endproc
|
|
.size ___tls_get_addr, .-___tls_get_addr
|