mirror of
https://sourceware.org/git/glibc.git
synced 2026-10-24 01:33:52 +03:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
98 lines
2.2 KiB
Makefile
98 lines
2.2 KiB
Makefile
# Copyright (C) 1991-2025 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <https://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
# Sub-makefile for socket portion of the library.
|
|
#
|
|
subdir := socket
|
|
|
|
include ../Makeconfig
|
|
|
|
headers := \
|
|
bits/sockaddr.h \
|
|
bits/socket.h \
|
|
bits/socket2.h \
|
|
bits/types/struct_osockaddr.h \
|
|
net/if.h \
|
|
sys/socket.h \
|
|
sys/socketvar.h \
|
|
sys/un.h \
|
|
# headers
|
|
|
|
routines := \
|
|
accept \
|
|
accept4 \
|
|
bind \
|
|
connect \
|
|
getpeername \
|
|
getsockname \
|
|
getsockopt \
|
|
isfdtype \
|
|
listen \
|
|
opensock \
|
|
recv \
|
|
recvfrom \
|
|
recvmmsg \
|
|
recvmsg \
|
|
send \
|
|
sendmmsg \
|
|
sendmsg \
|
|
sendto \
|
|
setsockopt \
|
|
shutdown \
|
|
sockaddr_un_set \
|
|
sockatmark \
|
|
socket \
|
|
socketpair \
|
|
# routines
|
|
|
|
# Exclude fortified routines from being built with _FORTIFY_SOURCE
|
|
routines_no_fortify += \
|
|
recv \
|
|
recvfrom \
|
|
# routines_no_fortify
|
|
|
|
tests := \
|
|
tst-accept4 \
|
|
tst-cmsg_cloexec \
|
|
tst-cmsghdr \
|
|
tst-connect \
|
|
tst-shutdown \
|
|
tst-sockopt \
|
|
# tests
|
|
|
|
tests-internal := \
|
|
tst-sockaddr_un_set \
|
|
# tests-internal
|
|
|
|
tests-time64 := \
|
|
tst-sockopt-time64 \
|
|
# tests
|
|
|
|
aux := sa_len
|
|
|
|
include ../Rules
|
|
|
|
CFLAGS-recv.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-recvfrom.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-sendto.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-recvmsg.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-sendmsg.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-send.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-connect.c += -fexceptions -fasynchronous-unwind-tables
|
|
CFLAGS-accept.c += -fexceptions -fasynchronous-unwind-tables
|