mirror of
https://sourceware.org/git/glibc.git
synced 2025-08-08 17:42:12 +03:00
848f0e46f0
Compiler generates the following instruction sequence for dynamic TLS access: leal tls_var@tlsgd(,%ebx,1), %eax call ___tls_get_addr@PLT CALL instruction is transparent to compiler which assumes all registers, except for EFLAGS, AX, CX, and DX, are unchanged after CALL. But ___tls_get_addr is a normal function which doesn't preserve any vector registers. 1. Rename the generic __tls_get_addr function to ___tls_get_addr_internal. 2. Change ___tls_get_addr to a wrapper function with implementations for FNSAVE, FXSAVE, XSAVE and XSAVEC to save and restore all vector registers. 3. dl-tlsdesc-dynamic.h has: _dl_tlsdesc_dynamic: /* Like all TLS resolvers, preserve call-clobbered registers. We need two scratch regs anyway. */ subl $32, %esp cfi_adjust_cfa_offset (32) It is wrong to use movl %ebx, -28(%esp) movl %esp, %ebx cfi_def_cfa_register(%ebx) ... mov %ebx, %esp cfi_def_cfa_register(%esp) movl -28(%esp), %ebx to preserve EBX on stack. Fix it with: movl %ebx, 28(%esp) movl %esp, %ebx cfi_def_cfa_register(%ebx) ... mov %ebx, %esp cfi_def_cfa_register(%esp) movl 28(%esp), %ebx 4. Update _dl_tlsdesc_dynamic to call ___tls_get_addr_internal directly. 5. Add have-test-mtls-traditional to compile tst-tls23-mod.c with traditional TLS variant to verify the fix. 6. Define DL_RUNTIME_RESOLVE_REALIGN_STACK in sysdeps/x86/sysdep.h. This fixes BZ #32996. Co-Authored-By: Adhemerval Zanella <adhemerval.zanella@linaro.org> Signed-off-by: H.J. Lu <hjl.tools@gmail.com> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
76 lines
2.1 KiB
Makefile
76 lines
2.1 KiB
Makefile
ifeq ($(subdir),string)
|
|
CFLAGS-memcmp.c += -Wno-uninitialized
|
|
endif
|
|
|
|
ifeq ($(subdir),elf)
|
|
# extra shared linker files to link into dl-allobjs.so and libc
|
|
sysdep-dl-routines += dl-machine hwcapinfo
|
|
sysdep_routines += dl-machine hwcapinfo
|
|
# extra shared linker files to link only into dl-allobjs.so
|
|
sysdep-rtld-routines += dl-machine hwcapinfo
|
|
|
|
modules-names += mod-tlsopt-powerpc
|
|
mod-tlsopt-powerpc.so-no-z-defs = yes
|
|
tests += tst-tlsopt-powerpc
|
|
$(objpfx)tst-tlsopt-powerpc: $(objpfx)mod-tlsopt-powerpc.so
|
|
|
|
tests-static += tst-cache-ppc-static
|
|
tests-internal += tst-cache-ppc-static
|
|
|
|
ifeq (yes,$(build-shared))
|
|
modules-names += mod-cache-ppc
|
|
tests += tst-cache-ppc tst-cache-ppc-static-dlopen
|
|
tests-static += tst-cache-ppc-static-dlopen
|
|
test-internal-extras += mod-cache-ppc
|
|
|
|
mod-cache-ppc.so-no-z-defs = yes
|
|
tst-cache-ppc-static-dlopen-ENV = LD_LIBRARY_PATH=$(objpfx):$(common-objpfx):$(common-objpfx)elf
|
|
$(objpfx)tst-cache-ppc-static-dlopen.out: $(objpfx)mod-cache-ppc.so
|
|
|
|
$(objpfx)tst-cache-ppc: $(objpfx)mod-cache-ppc.so
|
|
|
|
# The test checks if the __tls_get_addr does not clobber caller-saved
|
|
# register, so disable the powerpc specific optimization to force a
|
|
# __tls_get_addr call.
|
|
LDFLAGS-tst-tls23-mod.so = -Wl,--no-tls-get-addr-optimize
|
|
endif
|
|
|
|
ifneq (no,$(multi-arch))
|
|
tests-static += tst-tlsifunc-static
|
|
tests-internal += tst-tlsifunc-static
|
|
ifeq (yes,$(build-shared))
|
|
tests-internal += tst-tlsifunc
|
|
endif # build-shared
|
|
endif # multi-arch
|
|
endif # subdir = elf
|
|
|
|
ifeq ($(subdir),setjmp)
|
|
ifeq (yes,$(build-shared))
|
|
sysdep_routines += novmx-longjmp novmx-sigjmp
|
|
endif
|
|
endif
|
|
|
|
ifeq ($(subdir),csu)
|
|
# get offset to rtld_global._dl_hwcap and rtld_global._dl_hwcap2
|
|
gen-as-const-headers += rtld-global-offsets.sym
|
|
# get offset to __locale_struct.__ctype_tolower
|
|
gen-as-const-headers += locale-defines.sym
|
|
endif
|
|
|
|
ifeq ($(subdir),nptl)
|
|
tests-internal += test-get_hwcap test-get_hwcap-static
|
|
tests-static += test-get_hwcap-static
|
|
endif
|
|
|
|
ifeq ($(subdir),misc)
|
|
sysdep_headers += sys/platform/ppc.h
|
|
tests += test-gettimebase
|
|
tests += tst-set_ppr
|
|
endif
|
|
|
|
ifeq ($(subdir),wcsmbs)
|
|
CFLAGS-wcscpy.c += -DUNROLL_NTIMES=8
|
|
CFLAGS-wcschr.c += -DUNROLL_NTIMES=8
|
|
CFLAGS-wcsrchr.c += -DUNROLL_NTIMES=8
|
|
endif
|