mirror of
https://sourceware.org/git/glibc.git
synced 2025-08-05 19:35:52 +03:00
3a3fb2ed83
And simplify the interface of support_capture_subprogram_self_sgid.
Use the existing framework for temporary directories (now with
mode 0700) and directory/file deletion. Handle all execution
errors within support_capture_subprogram_self_sgid. In particular,
this includes test failures because the invoked program did not
exit with exit status zero. Existing tests that expect exit
status 42 are adjusted to use zero instead.
In addition, fix callers not to call exit (0) with test failures
pending (which may mask them, especially when running with --direct).
Fixes commit 35fc356fa3
("elf: Fix subprocess status handling for tst-dlopen-sgid (bug 32987)").
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
86 lines
2.5 KiB
C
86 lines
2.5 KiB
C
/* Copyright (C) 2012-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
/* Test that secure_getenv works by invoking the test as a SGID
|
|
program with a group ID from the supplementary group list. This
|
|
test can fail spuriously if the user is not a member of a suitable
|
|
supplementary group. */
|
|
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <stdlib.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
#include <unistd.h>
|
|
|
|
#include <support/check.h>
|
|
#include <support/support.h>
|
|
#include <support/capture_subprocess.h>
|
|
#include <support/test-driver.h>
|
|
|
|
static char MAGIC_ARGUMENT[] = "run-actual-test";
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
if (getenv ("PATH") == NULL)
|
|
{
|
|
printf ("PATH not set\n");
|
|
exit (1);
|
|
}
|
|
if (secure_getenv ("PATH") == NULL)
|
|
{
|
|
printf ("PATH not set according to secure_getenv\n");
|
|
exit (1);
|
|
}
|
|
if (strcmp (getenv ("PATH"), secure_getenv ("PATH")) != 0)
|
|
{
|
|
printf ("PATH mismatch (%s, %s)\n",
|
|
getenv ("PATH"), secure_getenv ("PATH"));
|
|
exit (1);
|
|
}
|
|
|
|
support_capture_subprogram_self_sgid (MAGIC_ARGUMENT);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
alternative_main (int argc, char **argv)
|
|
{
|
|
if (argc == 2 && strcmp (argv[1], MAGIC_ARGUMENT) == 0)
|
|
{
|
|
if (getgid () == getegid ())
|
|
/* This can happen if the file system is mounted nosuid. */
|
|
FAIL_UNSUPPORTED ("SGID failed: GID and EGID match (%jd)\n",
|
|
(intmax_t) getgid ());
|
|
if (getenv ("PATH") == NULL)
|
|
FAIL_EXIT (3, "PATH variable not present\n");
|
|
if (secure_getenv ("PATH") != NULL)
|
|
FAIL_EXIT (4, "PATH variable not filtered out\n");
|
|
|
|
support_record_failure_barrier ();
|
|
exit (EXIT_SUCCESS);
|
|
}
|
|
}
|
|
|
|
#define PREPARE alternative_main
|
|
#include <support/test-driver.c>
|