mirror of
https://sourceware.org/git/glibc.git
synced 2025-08-08 17:42:12 +03:00
eeb7b079d5
The iovec size should account for all substrings between each conversion specification. For the format: "abc %s efg" The list of substrings are: ["abc ", arg, " efg] which is 2 times the number of maximum arguments *plus* one. This issue triggered 'out of bounds' errors by stdlib/tst-bz20544 when glibc is built with experimental UBSAN support [1]. Besides adjusting the iovec size, a new runtime and check is added to avoid wrong __libc_message_impl usage. Checked on x86_64-linux-gnu. [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/ubsan-undef Co-authored-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
49 lines
1.5 KiB
C
49 lines
1.5 KiB
C
/* Internal test to verify __libc_fatal.
|
|
Copyright (C) 2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <signal.h>
|
|
#include <stdio.h>
|
|
|
|
#include <support/check.h>
|
|
#include <support/capture_subprocess.h>
|
|
|
|
static _Noreturn void
|
|
run_libc_message (void *closure)
|
|
{
|
|
/* We only support 4 arguments. Call with 5 to trigger failure. */
|
|
__libc_message_impl ("%s %s %s %s %s\n", "1", "2", "3", "4", "5");
|
|
__builtin_unreachable ();
|
|
}
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
struct support_capture_subprocess result
|
|
= support_capture_subprocess (run_libc_message, NULL);
|
|
support_capture_subprocess_check (&result, "libc_message", -SIGABRT,
|
|
sc_allow_stderr);
|
|
|
|
TEST_COMPARE_STRING (result.err.buffer, IOVEC_MAX_ERR_MSG);
|
|
|
|
support_capture_subprocess_free (&result);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|