lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-30 22:43:12 +03:00
Code Activity

Fix -Wempty-body warnings in Hurd-specific code.

Browse Source 
This patch fixes -Wempty-body warnings in Hurd-specific code that show
up building glibc with -Wextra.

Note: there also such warnings on many platforms arising from the
default definition of HP_TIMING_NOW in sysdeps/generic/hp-timing.h,
but no change there is proposed in this patch because of other changes
under discussion in that area that would result in a nonempty
definition.

Tested with build-many-glibcs.py.

	* hurd/hurdinit.c (_hurd_init): Use braces around empty body of an
	if statement.
This commit is contained in:
Joseph Myers
2019-02-27 13:58:56 +00:00
parent c4f50205e1
commit f627dd4da8
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -1,5 +1,8 @@
2019-02-27 Joseph Myers <joseph@codesourcery.com> 2019-02-27 Joseph Myers <joseph@codesourcery.com>
* hurd/hurdinit.c (_hurd_init): Use braces around empty body of an
if statement.
* benchtests/bench-strcpy.c (do_test): Use space before '('. * benchtests/bench-strcpy.c (do_test): Use space before '('.
* benchtests/bench-string.h (cmdline_process_function): Likewise. * benchtests/bench-string.h (cmdline_process_function): Likewise.
* benchtests/bench-strlen.c (do_test): Likewise. * benchtests/bench-strlen.c (do_test): Likewise.

10
hurd/hurdinit.c
View File

@ -100,10 +100,12 @@ _hurd_init (int flags, char **argv,
portarraysize * sizeof (mach_port_t)); portarraysize * sizeof (mach_port_t));
if (flags & EXEC_SECURE) if (flags & EXEC_SECURE)
/* XXX if secure exec, elide environment variables {
which the library uses and could be security holes. /* XXX if secure exec, elide environment variables
CORESERVER, COREFILE which the library uses and could be security holes.
*/ ; CORESERVER, COREFILE
*/
}
/* Call other things which want to do some initialization. These are not /* Call other things which want to do some initialization. These are not
on the __libc_subinit hook because things there like to be able to on the __libc_subinit hook because things there like to be able to