lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-07 06:43:00 +03:00
Code Activity

Fix build failures with -DDEBUG.

Browse Source 
[BZ #19443]
        * crypt/crypt_util.c [DEBUG] (_ufc_prbits): Correct format string.
        [DEBUG] (_ufc_set_bits): Declare used.
        * iconv/gconv_dl.c [DEBUG]: Add a missing include directive.
        [DEBUG] (print_all): Declare used.
        * resolv/res_send.c [DEBUG] (__libc_res_nsend): Explicitly convert
        operands of the ternary ?: expression to target type.
        * stdlib/rshift.c [DEBUG] (mpn_rshift): Use assert() instead of
        calling the undeclared abort.
        * time/mktime.c [DEBUG] (DEBUG): Rename to DEBUG_MKTIME.
This commit is contained in:
Martin Sebor
2016-01-15 11:07:41 -07:00
parent ad37480c4b
commit f2b3078e6a
6 changed files with 30 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
ChangeLog
View File

@@ -1,3 +1,16 @@
2016-01-15 Martin Sebor <msebor@redhat.com>
[BZ #19443]
* crypt/crypt_util.c [DEBUG] (_ufc_prbits): Correct format string.
[DEBUG] (_ufc_set_bits): Declare used.
* iconv/gconv_dl.c [DEBUG]: Add a missing include directive.
[DEBUG] (print_all): Declare used.
* resolv/res_send.c [DEBUG] (__libc_res_nsend): Explicitly convert
operands of the ternary ?: expression to target type.
* stdlib/rshift.c [DEBUG] (mpn_rshift): Use assert() instead of
calling the undeclared abort.
* time/mktime.c [DEBUG] (DEBUG): Rename to DEBUG_MKTIME.
2016-01-15 Martin Sebor <msebor@redhat.com> 2016-01-15 Martin Sebor <msebor@redhat.com>
[BZ #18755] [BZ #18755]

4
crypt/crypt_util.c
View File

@@ -271,12 +271,12 @@ _ufc_prbits (ufc_long *a, int n)
t=8*i+j; t=8*i+j;
tmp|=(a[t/24] & BITMASK[t % 24])?bytemask[j]:0; tmp|=(a[t/24] & BITMASK[t % 24])?bytemask[j]:0;
} }
(void)printf("%02x ",tmp); (void)printf("%02lx ", tmp);
} }
printf(" "); printf(" ");
} }
static void static void __attribute__ ((unused))
_ufc_set_bits (ufc_long v, ufc_long *b) _ufc_set_bits (ufc_long v, ufc_long *b)
{ {
ufc_long i; ufc_long i;

5
iconv/gconv_dl.c
View File

@@ -219,6 +219,9 @@ libc_freeres_fn (free_mem)
#ifdef DEBUG #ifdef DEBUG
#include <stdio.h>
static void static void
do_print (const void *nodep, VISIT value, int level) do_print (const void *nodep, VISIT value, int level)
{ {
@@ -231,7 +234,7 @@ do_print (const void *nodep, VISIT value, int level)
obj->name, obj->counter); obj->name, obj->counter);
} }
static void static void __attribute__ ((used))
print_all (void) print_all (void)
{ {
__twalk (loaded, do_print); __twalk (loaded, do_print);

4
resolv/res_send.c
View File

@@ -499,8 +499,8 @@ __libc_res_nsend(res_state statp, const u_char *buf, int buflen,
(stdout, ";; Querying server (# %d) address = %s\n", (stdout, ";; Querying server (# %d) address = %s\n",
ns + 1, inet_ntop(nsap->sa_family, ns + 1, inet_ntop(nsap->sa_family,
(nsap->sa_family == AF_INET6 (nsap->sa_family == AF_INET6
? &((struct sockaddr_in6 *) nsap)->sin6_addr ? (void *) &((struct sockaddr_in6 *) nsap)->sin6_addr
: &((struct sockaddr_in *) nsap)->sin_addr), : (void *) &((struct sockaddr_in *) nsap)->sin_addr),
tmpbuf, sizeof (tmpbuf)))); tmpbuf, sizeof (tmpbuf))));
if (__glibc_unlikely (v_circuit)) { if (__glibc_unlikely (v_circuit)) {

7
stdlib/rshift.c
View File

@@ -21,6 +21,8 @@ along with the GNU MP Library; see the file COPYING.LIB. If not, see
#include <gmp.h> #include <gmp.h>
#include "gmp-impl.h" #include "gmp-impl.h"
#include <assert.h>
/* Shift U (pointed to by UP and USIZE limbs long) CNT bits to the right /* Shift U (pointed to by UP and USIZE limbs long) CNT bits to the right
and store the USIZE least significant limbs of the result at WP. and store the USIZE least significant limbs of the result at WP.
The bits shifted out to the right are returned. The bits shifted out to the right are returned.
@@ -40,10 +42,7 @@ mpn_rshift (register mp_ptr wp,
register mp_size_t i; register mp_size_t i;
mp_limb_t retval; mp_limb_t retval;
#ifdef DEBUG assert (usize != 0 && cnt != 0);
if (usize == 0 || cnt == 0)
abort ();
#endif
sh_1 = cnt; sh_1 = cnt;

12
time/mktime.c
View File

@@ -19,7 +19,7 @@
/* Define this to have a standalone program to test this implementation of /* Define this to have a standalone program to test this implementation of
mktime. */ mktime. */
/* #define DEBUG 1 */ /* #define DEBUG_MKTIME 1 */
#ifndef _LIBC #ifndef _LIBC
# include <config.h> # include <config.h>
@@ -38,13 +38,13 @@
#include <string.h> /* For the real memcpy prototype. */ #include <string.h> /* For the real memcpy prototype. */
#if defined DEBUG && DEBUG #if defined DEBUG_MKTIME && DEBUG_MKTIME
# include <stdio.h> # include <stdio.h>
# include <stdlib.h> # include <stdlib.h>
/* Make it work even if the system's libc has its own mktime routine. */ /* Make it work even if the system's libc has its own mktime routine. */
# undef mktime # undef mktime
# define mktime my_mktime # define mktime my_mktime
#endif /* DEBUG */ #endif /* DEBUG_MKTIME */
/* Some of the code in this file assumes that signed integer overflow /* Some of the code in this file assumes that signed integer overflow
silently wraps around. This assumption can't easily be programmed silently wraps around. This assumption can't easily be programmed
@@ -600,7 +600,7 @@ libc_hidden_def (mktime)
libc_hidden_weak (timelocal) libc_hidden_weak (timelocal)
#endif #endif
#if defined DEBUG && DEBUG #if defined DEBUG_MKTIME && DEBUG_MKTIME
static int static int
not_equal_tm (const struct tm *a, const struct tm *b) not_equal_tm (const struct tm *a, const struct tm *b)
@@ -732,10 +732,10 @@ main (int argc, char **argv)
return status; return status;
} }
#endif /* DEBUG */ #endif /* DEBUG_MKTIME */
/* /*
Local Variables: Local Variables:
compile-command: "gcc -DDEBUG -I. -Wall -W -O2 -g mktime.c -o mktime" compile-command: "gcc -DDEBUG_MKTIME -I. -Wall -W -O2 -g mktime.c -o mktime"
End: End:
*/ */