lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-30 22:43:12 +03:00
Code Activity

Clear DF_1_NODELETE flag only for failed to load library.

Browse Source 
https://sourceware.org/bugzilla/show_bug.cgi?id=18778

If dlopen fails to load an object that has triggered loading libpthread it
causes ld.so to unload libpthread because its DF_1_NODELETE flags has been
forcefully cleared. The next call to __rtdl_unlock_lock_recursive will crash
since pthread_mutex_unlock no longer exists.

This patch moves l->l_flags_1 &= ~DF_1_NODELETE out of loop through all loaded
libraries and performs the action only on inconsistent one.

	[BZ #18778]
	* elf/Makefile (tests): Add Add tst-nodelete2.
	(modules-names): Add tst-nodelete2mod.
	(tst-nodelete2mod.so-no-z-defs): New.
	($(objpfx)tst-nodelete2): Likewise.
	($(objpfx)tst-nodelete2.out): Likewise.
	(LDFLAGS-tst-nodelete2): Likewise.
	* elf/dl-close.c (_dl_close_worker): Move DF_1_NODELETE clearing
	out of loop through all loaded libraries.
	* elf/tst-nodelete2.c: New file.
	* elf/tst-nodelete2mod.c: Likewise.
This commit is contained in:
Maxim Ostapenko
2015-08-10 10:47:54 +03:00
committed by Andreas Schwab
parent dc8a7ff24d
commit f25238ffe0
6 changed files with 71 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
elf/tst-nodelete2mod.c Normal file
View File

@ -0,0 +1,7 @@
/* Undefined symbol. */
extern int not_exist (void);
int foo (void)
{
return not_exist ();
}