lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-07 06:43:00 +03:00
Code Activity

support: Use const char * argument in support_capture_subprogram_self_sgid

Browse Source 
The function does not modify the passed-in string, so make this clear
via the prototype.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
This commit is contained in:
Florian Weimer
2025-05-20 19:36:02 +02:00
parent 2071666d03
commit f0c09fe616
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
support/capture_subprocess.h
View File

@@ -45,8 +45,7 @@ struct support_capture_subprocess support_capture_subprogram
/* Copy the running program into a setgid binary and run it with CHILD_ID /* Copy the running program into a setgid binary and run it with CHILD_ID
argument. If execution is successful, return the exit status of the child argument. If execution is successful, return the exit status of the child
program, otherwise return a non-zero failure exit code. */ program, otherwise return a non-zero failure exit code. */
int support_capture_subprogram_self_sgid int support_capture_subprogram_self_sgid (const char *child_id);
(char *child_id);
/* Deallocate the subprocess data captured by /* Deallocate the subprocess data captured by
support_capture_subprocess. */ support_capture_subprocess. */

6
support/support_capture_subprocess.c
View File

@@ -110,7 +110,7 @@ support_capture_subprogram (const char *file, char *const argv[],
safely make it SGID with the TARGET group ID. Then runs the safely make it SGID with the TARGET group ID. Then runs the
executable. */ executable. */
static int static int
copy_and_spawn_sgid (char *child_id, gid_t gid) copy_and_spawn_sgid (const char *child_id, gid_t gid)
{ {
char *dirname = xasprintf ("%s/tst-tunables-setuid.%jd", char *dirname = xasprintf ("%s/tst-tunables-setuid.%jd",
test_dir, (intmax_t) getpid ()); test_dir, (intmax_t) getpid ());
@@ -182,7 +182,7 @@ copy_and_spawn_sgid (char *child_id, gid_t gid)
ret = 0; ret = 0;
infd = outfd = -1; infd = outfd = -1;
char * const args[] = {execname, child_id, NULL}; char * const args[] = {execname, (char *) child_id, NULL};
status = support_subprogram_wait (args[0], args); status = support_subprogram_wait (args[0], args);
@@ -211,7 +211,7 @@ err:
} }
int int
support_capture_subprogram_self_sgid (char *child_id) support_capture_subprogram_self_sgid (const char *child_id)
{ {
gid_t target = 0; gid_t target = 0;
const int count = 64; const int count = 64;