lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

Fix string/bug-strncat1.c build with GCC 8.

Browse Source 
GCC 8 warns about strncat calls with truncated output.
string/bug-strncat1.c tests such a call; this patch disables the
warning for it.

Tested (compilation) with GCC 8 for x86_64-linux-gnu with
build-many-glibcs.py (in conjunction with Martin's patch to allow
glibc to build).

	* string/bug-strncat1.c: Include <libc-diag.h>.
	(main): Disable -Wstringop-truncation for strncat call for GCC 8.
This commit is contained in:
Joseph Myers
2017-11-14 17:50:36 +00:00
parent a259f5d388
commit ec72135e5f
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2017-11-14 Joseph Myers <joseph@codesourcery.com>
* string/bug-strncat1.c: Include <libc-diag.h>.
(main): Disable -Wstringop-truncation for strncat call for GCC 8.
2017-11-13 Claude Paroz <claude@2xlibre.net> 2017-11-13 Claude Paroz <claude@2xlibre.net>
[BZ #22387] [BZ #22387]

8
string/bug-strncat1.c
View File

@ -4,13 +4,21 @@
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <libc-diag.h>
char d[3] = "\0\1\2"; char d[3] = "\0\1\2";
int int
main (void) main (void)
{ {
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (8, 0)
/* GCC 8 warns about strncat truncating output; this is deliberately
tested here. */
DIAG_IGNORE_NEEDS_COMMENT (8, "-Wstringop-truncation");
#endif
strncat (d, "\5\6", 1); strncat (d, "\5\6", 1);
DIAG_POP_NEEDS_COMMENT;
if (d[0] != '\5') if (d[0] != '\5')
{ {
puts ("d[0] != '\\5'"); puts ("d[0] != '\\5'");