lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-08 17:42:12 +03:00
Code Activity

Fix crash on reloading of gai data in nscd.

Browse Source
This commit is contained in:
Ulrich Drepper
2010-04-09 21:38:20 -07:00
parent 17ad387727
commit ea42a20cae
3 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@@ -1,3 +1,11 @@
2010-04-09 Ulrich Drepper <drepper@redhat.com>
* nscd/aicache.c (addhstaiX): Correct passing memory to address
list to gethostbyname4_r functions.
* resolv/nss_dns/dns-host.c (gaih_getanswer_slice): Optimize
copying of h_name.
2010-04-09 Roland McGrath <roland@redhat.com> 2010-04-09 Roland McGrath <roland@redhat.com>
* Makerules ($(common-objpfx)libc-abis.h): Depend on libc-abis.stamp. * Makerules ($(common-objpfx)libc-abis.h): Depend on libc-abis.stamp.

10
nscd/aicache.c
View File

@@ -1,5 +1,5 @@
/* Cache handling for host lookup. /* Cache handling for host lookup.
Copyright (C) 2004-2008, 2009 Free Software Foundation, Inc. Copyright (C) 2004-2008, 2009, 2010 Free Software Foundation, Inc.
This file is part of the GNU C Library. This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@redhat.com>, 2004. Contributed by Ulrich Drepper <drepper@redhat.com>, 2004.
@@ -111,7 +111,7 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req,
int old_res_options = _res.options; int old_res_options = _res.options;
_res.options &= ~RES_USE_INET6; _res.options &= ~RES_USE_INET6;
size_t tmpbuf6len = 512; size_t tmpbuf6len = 1024;
char *tmpbuf6 = alloca (tmpbuf6len); char *tmpbuf6 = alloca (tmpbuf6len);
size_t tmpbuf4len = 0; size_t tmpbuf4len = 0;
char *tmpbuf4 = NULL; char *tmpbuf4 = NULL;
@@ -133,9 +133,11 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req,
"gethostbyname4_r"); "gethostbyname4_r");
if (fct4 != NULL) if (fct4 != NULL)
{ {
struct gaih_addrtuple *at = NULL; struct gaih_addrtuple atmem;
struct gaih_addrtuple *at;
while (1) while (1)
{ {
at = &atmem;
rc6 = 0; rc6 = 0;
herrno = 0; herrno = 0;
status[1] = DL_CALL_FCT (fct4, (key, &at, tmpbuf6, tmpbuf6len, status[1] = DL_CALL_FCT (fct4, (key, &at, tmpbuf6, tmpbuf6len,
@@ -153,7 +155,7 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req,
goto next_nip; goto next_nip;
/* We found the data. Count the addresses and the size. */ /* We found the data. Count the addresses and the size. */
for (const struct gaih_addrtuple *at2 = at; at2 != NULL; for (const struct gaih_addrtuple *at2 = at = &atmem; at2 != NULL;
at2 = at2->next) at2 = at2->next)
{ {
++naddrs; ++naddrs;

16
resolv/nss_dns/dns-host.c
View File

@@ -1050,7 +1050,7 @@ gaih_getanswer_slice (const querybuf *answer, int anslen, const char *qname,
++had_error; ++had_error;
continue; continue;
} }
if (*firstp) if (*firstp && canon == NULL)
{ {
h_name = buffer; h_name = buffer;
buffer += h_namelen; buffer += h_namelen;
@@ -1166,19 +1166,7 @@ gaih_getanswer_slice (const querybuf *answer, int anslen, const char *qname,
if (ttl != 0 && ttlp != NULL) if (ttl != 0 && ttlp != NULL)
*ttlp = ttl; *ttlp = ttl;
if (canon != NULL) (*pat)->name = canon ?: h_name;
{
(*pat)->name = canon;
/* Reclaim buffer space. */
if (h_name + h_namelen == buffer)
{
buffer = h_name;
buflen += h_namelen;
}
}
else
(*pat)->name = h_name;
*firstp = 0; *firstp = 0;
} }