lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-30 22:43:12 +03:00
Code Activity

nss_dns: Do not replace root domain with empty string

Browse Source 
The purpose of the bp[0] == '.' check is unclear.  Only the root domain
starts with '.'.  The empty string is accepted as a domain name in many
places, denoting the root, but using it implicitly is confusing.
This commit is contained in:
Florian Weimer
2019-04-11 11:37:47 +02:00
parent 32d85c116d
commit e3f454bac0
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2019-04-11 Florian Weimer <fweimer@redhat.com>
* resolv/nss_dns/dns-network.c (getanswer_r): Do not replace root
domain with empty string.
* resolv/nss_dns/dns-host.c (getanswer_r): Likewise.
2019-04-11 Florian Weimer <fweimer@redhat.com> 2019-04-11 Florian Weimer <fweimer@redhat.com>
* include/alloc_buffer.h (alloc_buffer_alloc_bytes): Update * include/alloc_buffer.h (alloc_buffer_alloc_bytes): Update

3
resolv/nss_dns/dns-host.c
View File

@ -706,9 +706,6 @@ getanswer_r (struct resolv_context *ctx,
n = -1; n = -1;
} }
if (n > 0 && bp[0] == '.')
bp[0] = '\0';
if (__glibc_unlikely (n < 0)) if (__glibc_unlikely (n < 0))
{ {
*errnop = errno; *errnop = errno;

3
resolv/nss_dns/dns-network.c
View File

@ -345,9 +345,6 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result,
n = -1; n = -1;
} }
if (n > 0 && bp[0] == '.')
bp[0] = '\0';
if (n < 0 || res_dnok (bp) == 0) if (n < 0 || res_dnok (bp) == 0)
break; break;
cp += n; cp += n;