lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-08 17:42:12 +03:00
Code Activity

sparc: Fix la_symbind for bind-now (BZ 23734)

Browse Source 
The sparc ABI has multiple cases on how to handle JMP_SLOT relocations,
(sparc_fixup_plt/sparc64_fixup_plt).  For BINDNOW, _dl_audit_symbind
will be responsible to setup the final relocation value; while for
lazy binding _dl_fixup/_dl_profile_fixup will call the audit callback
and tail cail elf_machine_fixup_plt (which will call
sparc64_fixup_plt).

This patch fixes by issuing the SPARC specific routine on bindnow and
forwarding the audit value to elf_machine_fixup_plt for lazy resolution.
It fixes the la_symbind for bind-now tests on sparc64 and sparcv9:

  elf/tst-audit24a
  elf/tst-audit24b
  elf/tst-audit24c
  elf/tst-audit24d

Checked on sparc64-linux-gnu and sparcv9-linux-gnu.
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
This commit is contained in:
Adhemerval Zanella
2023-07-10 17:01:00 -03:00
parent ca230f5833
commit dddc88587a
9 changed files with 66 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
sysdeps/sparc/dl-lookupcfg.h Normal file
View File

@@ -0,0 +1,49 @@
/* Configuration of lookup functions. SPARC64 version.
Copyright (C) 2023 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
/* The type of the return value of fixup/profile_fixup. */
#define DL_FIXUP_VALUE_TYPE ElfW(Addr)
/* Construct a value of type DL_FIXUP_VALUE_TYPE from a code address
and a link map. */
#define DL_FIXUP_MAKE_VALUE(map, addr) (addr)
/* Extract the code address from a value of type DL_FIXUP_MAKE_VALUE.
*/
#define DL_FIXUP_VALUE_CODE_ADDR(value) (value)
#define DL_FIXUP_VALUE_ADDR(value) (value)
#define DL_FIXUP_ADDR_VALUE(addr) (addr)
#define DL_FIXUP_BINDNOW_ADDR_VALUE(addr) (addr)
/* For bindnow, _dl_audit_symbind will be responsible to setup the final value
while for lazy binding _dl_fixup/_dl_profile_fixup will call the audit
callbacks and tail cail elf_machine_fixup_plt. */
#ifdef __arch64__
# define DL_SPARC_FIXUP(l, r, value, new_value) \
sparc64_fixup_plt (l, r, value, new_value, (r)->r_addend, 0)
#else
# define DL_SPARC_FIXUP(l, r, value, new_value) \
sparc_fixup_plt (r, value, new_value, 0, 1)
#endif
#define DL_FIXUP_BINDNOW_RELOC(l, reloc, value, new_value, st_value, lazy) \
({ \
if (lazy) \
(*value) = st_value; \
else \
{ \
const PLTREL *__r = (reloc); \
DL_SPARC_FIXUP (l, __r, value, new_value); \
} \
})